Skip to content

Conversation

carolineechen
Copy link
Contributor

Expose the rolloff parameter in resampling functions, which is can be used to control the degree of anti-aliasing and amount of high frequencies being filtered out in resampling.

cc #1487

@mthrok
Copy link
Contributor

mthrok commented May 5, 2021

Hi @adefossez

We are revisiting resampling functions in torchaudio, and we appreciate if you can take a look at this PR. I remember you mention that rolloff affects aliasing for both downsampling and upsampling. I think this PR is harmless and uncontroversial, but extra eyes are nice.

@carolineechen carolineechen merged commit c274064 into pytorch:master May 10, 2021
@mthrok mthrok mentioned this pull request May 25, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants