Skip to content

Melscale torchscript bugfix #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 14, 2021
Merged

Melscale torchscript bugfix #1505

merged 4 commits into from
May 14, 2021

Conversation

borundev
Copy link
Contributor

Added a check in pre_scriptable method for MelScale to make that self.n_stft is not None at the time of scripting.

See #1454 for details.

@facebook-github-bot
Copy link
Contributor

Hi @borundev!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

mthrok
mthrok reviewed May 13, 2021
View reviewed changes
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

mthrok
mthrok approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@mthrok mthrok merged commit 8a86c46 into pytorch:master May 14, 2021
mthrok pushed a commit to mthrok/audio that referenced this pull request Dec 13, 2022
@apivovarov
Replace num_flat_features with torch.flatten (pytorch#1505)
580903e 
Apply the best practices from alexnet
https://github.com/pytorch/vision/blob/master/torchvision/models/alexnet.py#L48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mthrok mthrok mthrok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@borundev @facebook-github-bot @mthrok