Make test scripts runnable without being modules. #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to test against an installed wheel, as the torchaudio folder is no longer preferentially picked up when you run a test module. I had to move all tests in subfolders into the top level test directory to make this work, since you can't access .. modules without mucking around with sys.path (which I don't want to do.) NB: this BREAKS the syntax where you can run a test by saying `python -m test.test`. Instead, do `python test/test.py` or use the pytest runner. Signed-off-by: Edward Z. Yang <ezyang@fb.com>
|
Is there a reason for the test/compliance/init.py |
|
Yeah, so I can |
jamarshon
approved these changes
Jul 30, 2019
jamarshon
pushed a commit
to jamarshon/audio
that referenced
this pull request
Jul 31, 2019
This makes it easier to test against an installed wheel, as the torchaudio folder is no longer preferentially picked up when you run a test module. I had to move all tests in subfolders into the top level test directory to make this work, since you can't access .. modules without mucking around with sys.path (which I don't want to do.) NB: this BREAKS the syntax where you can run a test by saying `python -m test.test`. Instead, do `python test/test.py` or use the pytest runner. Signed-off-by: Edward Z. Yang <ezyang@fb.com> (cherry picked from commit 07b9b9b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to test against an installed wheel, as the
torchaudio folder is no longer preferentially picked up when
you run a test module.
I had to move all tests in subfolders into the top level test
directory to make this work, since you can't access .. modules
without mucking around with sys.path (which I don't want to do.)
NB: this BREAKS the syntax where you can run a test by
saying
python -m test.test. Instead, dopython test/test.pyor use the pytest runner.
Signed-off-by: Edward Z. Yang ezyang@fb.com