Skip to content

Conversation

@pearu
Copy link
Collaborator

@pearu pearu commented Nov 16, 2025

As in the title.

Fixes #4075

PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.

@pearu pearu requested a review from a team as a code owner November 16, 2025 20:48
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4131

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 895940d with merge base ee1a135 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Nov 16, 2025
@pearu pearu force-pushed the pearu/overdrive branch 2 times, most recently from 21f7bde to b09ac6d Compare November 18, 2025 10:37
@pearu
Copy link
Collaborator Author

pearu commented Nov 18, 2025

Possibly blocked by pytorch/pytorch#167923

@pearu pearu force-pushed the pearu/overdrive branch 3 times, most recently from ad2c823 to 3405b09 Compare November 20, 2025 07:56
@pearu
Copy link
Collaborator Author

pearu commented Nov 20, 2025

pytorch/audio / build-manywheel-py3_10-rocm7_1 fails because the latest cp310 in nightly is from Nov 13.

@pearu
Copy link
Collaborator Author

pearu commented Nov 20, 2025

Unit-tests on Windows GPU / build / windows-job (pull_request) fails in forced_align tests and the failure is not related to this PR.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pearu !

Comment on lines 3 to 4
#include <c10/cuda/CUDAException.h>
#include <c10/cuda/CUDAStream.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove these headers?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point yes, that is, after revising their usage and having the equivalent tools available in stable ABI/headeronly.

@pearu pearu merged commit e9a52a3 into pytorch:main Nov 20, 2025
70 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[STABLE ABI] Porting overdrive.cpp

2 participants