Undo dropping support for forced_align and rnnt_loss #4147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4147
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e679adf with merge base b3bb7bc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pearu
changed the title
pearu
force-pushed
the
pearu/undo-drop-1
branch
from
e6c1151 to
6c0f140
Compare
NicolasHug
approved these changes
Dec 8, 2025
Member
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks @pearu
We can probably remove the other usage of dropping_support and dropping_class_support, as well as their implementation now?
~/dev/audio (main*) » git grep -e dropping_class_support -e dropping_support nicolashug@nicolashug-fedora-PW0H326Y
src/torchaudio/_internal/module_utils.py:dropping_support = deprecated(DEPRECATION_MSG, version="2.9", remove=True)
src/torchaudio/_internal/module_utils.py:def dropping_class_support(c, msg=DEPRECATION_MSG):
src/torchaudio/_internal/module_utils.py:dropping_class_io_support = partial(dropping_class_support, msg=IO_DEPRECATION_MSG)
src/torchaudio/functional/__init__.py:from torchaudio._internal.module_utils import dropping_support
src/torchaudio/functional/__init__.py:forced_align = dropping_support(_forced_align)
src/torchaudio/functional/functional.py:from torchaudio._internal.module_utils import dropping_support
src/torchaudio/functional/functional.py:rnnt_loss = dropping_support(_rnnt_loss)
src/torchaudio/models/decoder/__init__.py:from torchaudio._internal.module_utils import dropping_class_support, dropping_support
src/torchaudio/models/decoder/__init__.py: item = dropping_class_support(orig_item)
src/torchaudio/models/decoder/__init__.py: item = dropping_support(orig_item)
src/torchaudio/transforms/__init__.py:from torchaudio._internal.module_utils import dropping_class_support
src/torchaudio/transforms/__init__.py:RNNTLoss = dropping_class_support(_RNNTLoss)
test/torchaudio_unittest/common_utils/func_utils.py: # like @deprecated or @dropping_support. Adding the decorators breaks
test/torchaudio_unittest/functional/torchscript_consistency_impl.py: # like @deprecated or @dropping_support. Adding the decorators breaks
d2c1439 to
4830cb9
Compare
pearu
force-pushed
the
pearu/undo-drop-1
branch
from
4830cb9 to
e679adf
Compare
Collaborator
Author
Yes, I have removed |
NicolasHug
approved these changes
Dec 8, 2025
This was referenced Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #4142, torchaudio is fully torch ABI stable that includes the extension operations forced_align and rnnt_loss_forward. So, we can continue supporting these in the future.
PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.