Skip to content

Conversation

mthrok
Copy link
Contributor

@mthrok mthrok commented Mar 30, 2020

From #466.
Similar to #480
It extracts librosa consistency test from test_functional module and put them in a dedicated module/class (test_librosa_consistency::TestFunctional).

@mthrok mthrok requested a review from vincentqb March 30, 2020 22:46
@vincentqb
Copy link
Contributor

Should librosa test in test_transforms.py also be moved?

Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As we discussed offline, the tests for transforms will be moved in a separate PR.

@vincentqb vincentqb merged commit a72dd83 into pytorch:master Mar 31, 2020
@mthrok mthrok deleted the reorg-librosa branch March 31, 2020 18:41
mthrok pushed a commit to mthrok/audio that referenced this pull request Feb 26, 2021
* Pin Docker version

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants