Make Kaldi fbank support cuda #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentqb
suggested changes
May 11, 2020
There was a problem hiding this comment.
nit:flake8
torchaudio/compliance/kaldi.py:93:1: E124 closing bracket does not match visual indentation
torchaudio/compliance/kaldi.py:555:1: W293 blank line contains whitespace
More importantly: not compatible with current windows setup?
Build-agent version 1.0.31788-6ad45373 (2020-05-07T13:35:11+0000)
Creating a dedicated VM with windows-server-2019-vs2019:stable image
failed to create host: Image windows-server-2019-vs2019:stable is not compatible with resource class l1.medium
failed to create host: Image windows-server-2019-vs2019:stable is not compatible with resource class l1.medium
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
==========================================
+ Coverage 89.00% 89.03% +0.02%
==========================================
Files 21 21
Lines 2255 2261 +6
==========================================
+ Hits 2007 2013 +6
Misses 248 248
Continue to review full report at Codecov.
|
It's unrelated. |
bhargavkathivarapu
pushed a commit
to bhargavkathivarapu/audio
that referenced
this pull request
May 19, 2020
* Make fbank support cuda * Reduce rtol for kaldi * fix test * fix flake8
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #613