WIP: Make get_info torchscript-able
#662
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthrok
changed the title
get_info torchscript-ableget_info torchscript-able
mpc001
pushed a commit
to mpc001/audio
that referenced
this pull request
Aug 4, 2023
The RNNModel puts the embedding table and the decoder parameters on a remote parameter server, and locally holds parameters for the LSTM module. The RNNModel overrides the forward() function to pass input and intermediate outputs across workers. And it also added a parameter_rrefs to return a list of RRefs of the model parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binds
get_infofunction viatorchscriptinstead ofpybind.Introduces the intermediate struct
SoxAudioInfothat is passed from C++ extension to Python,This is due to the fact that unlike
pybind11,torchscriptdoes not allow to expose arbitral C struct to Python (sox_encodinginfo_tandsox_signalinfo_t).This PR is built on / blocked by #625 .