Setup CUDA environment when running bisection and abtest #1141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xuzhao9
changed the title
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Aug 30, 2022
Upgrade CUDA version of torchbench as we are moving away from CUDA 11.3 This PR needs to land together with pytorch/benchmark#1141 RUN_TORCHBENCH: nvfuser TORCHBENCH_BRANCH: xz9/setup-cuda-compile Pull Request resolved: #84248 Approved by: https://github.com/erichan1, https://github.com/davidberard98
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 1, 2022
Summary: Upgrade CUDA version of torchbench as we are moving away from CUDA 11.3 This PR needs to land together with pytorch/benchmark#1141 RUN_TORCHBENCH: nvfuser TORCHBENCH_BRANCH: xz9/setup-cuda-compile Pull Request resolved: #84248 Approved by: https://github.com/erichan1, https://github.com/davidberard98 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e014bd8e4ef65377374640310cbafbccbcd0f5f7 Reviewed By: mehtanirav Differential Revision: D39171934 Pulled By: xuzhao9 fbshipit-source-id: 6c627b902b5d425f2b4dfd8666896cd4a69e1d93
xuzhao9
added a commit
that referenced
this pull request
Sep 6, 2022
Summary: CUDA 11.3 is being deprecated, and we are using environment variables to control the CUDA version instead of changing the link target of `/usr/local/cuda`. This has many benefits: - switching cuda version no longer needs sudo permission - support switching cuda versions at both runtime and compile time This PR also creates a `cuda_utils.py` to place all CUDA version related code. Pull Request resolved: #1141 Reviewed By: erichan1, davidberard98 Differential Revision: D39139827 Pulled By: xuzhao9 fbshipit-source-id: 6c305ab749c8cfc0d5bc8f15a86dc4a0a6d04a96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUDA 11.3 is being deprecated, and we are using environment variables to control the CUDA version instead of changing the link target of
/usr/local/cuda.This has many benefits:
This PR also creates a
cuda_utils.pyto place all CUDA version related code.