Skip to content

Conversation

@yanboliang
Copy link
Contributor

No description provided.

@yanboliang
Copy link
Contributor Author

This PR should works well after pytorch/pytorch#88963.

Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@yanboliang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Nov 17, 2022
These missing features come from pytorch/benchmark#1302, where we'd like to enable E2E hf_bert dynamo train/eval. The dependent [HuggingFace accelerate library](https://huggingface.co/docs/accelerate/index) requires these improvements.

Pull Request resolved: #88963
Approved by: https://github.com/jansel
@yanboliang yanboliang deleted the dynamo branch November 17, 2022 22:31
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
…ch#88963)

These missing features come from pytorch/benchmark#1302, where we'd like to enable E2E hf_bert dynamo train/eval. The dependent [HuggingFace accelerate library](https://huggingface.co/docs/accelerate/index) requires these improvements.

Pull Request resolved: pytorch#88963
Approved by: https://github.com/jansel
cclauss pushed a commit to cclauss/benchmark that referenced this pull request Jan 22, 2025
…tion values" in Windows codepath (pytorch#1302)

This applies a fix that used to exist in LLVM's downstream copy of
this library, from
llvm/llvm-project@948ce4e.

I presume this warning isn't present if built with MSVC or Clang-cl,
but it's printed in MinGW mode. As the benchmark library adds
-Werror, this is a fatal error when builtin MinGW mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants