-
Notifications
You must be signed in to change notification settings - Fork 325
Bump up the transformers version #1511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: To pick up a torchdynamo graph break fix in transformers, see huggingface/transformers#21648
xuzhao9
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Current CI errors are because of broken torchtext nightly build: #1504 |
desertfire
added a commit
to pytorch/pytorch
that referenced
this pull request
Mar 30, 2023
…rmers Summary: When we bump up the torchbench version pin last time, we found there were new graph breaks introduced with the trasformers version upgrade, see #96782. Turns out they are already fixed upstream, see huggingface/transformers#21648 and pytorch/benchmark#1511 [ghstack-poisoned]
desertfire
added a commit
to pytorch/pytorch
that referenced
this pull request
Mar 30, 2023
…rmers Summary: When we bump up the torchbench version pin last time, we found there were new graph breaks introduced with the trasformers version upgrade, see #96782. Turns out they are already fixed upstream, see huggingface/transformers#21648 and pytorch/benchmark#1511 ghstack-source-id: 8f2f284 Pull Request resolved: #98003
desertfire
added a commit
to pytorch/pytorch
that referenced
this pull request
Mar 30, 2023
… in transformers" Summary: When we bump up the torchbench version pin last time, we found there were new graph breaks introduced with the trasformers version upgrade, see #96782. Turns out they are already fixed upstream, see huggingface/transformers#21648 and pytorch/benchmark#1511 cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx [ghstack-poisoned]
desertfire
added a commit
to pytorch/pytorch
that referenced
this pull request
Mar 30, 2023
…rmers Summary: When we bump up the torchbench version pin last time, we found there were new graph breaks introduced with the trasformers version upgrade, see #96782. Turns out they are already fixed upstream, see huggingface/transformers#21648 and pytorch/benchmark#1511 ghstack-source-id: 05fe5d6 Pull Request resolved: #98003
desertfire
added a commit
to pytorch/pytorch
that referenced
this pull request
Mar 31, 2023
…amo graph breaks in transformers" Summary: When we bump up the torchbench version pin last time, we found there were new graph breaks introduced with the trasformers version upgrade, see #96782. Turns out they are already fixed upstream, see huggingface/transformers#21648 and pytorch/benchmark#1511 cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx [ghstack-poisoned]
desertfire
added a commit
to pytorch/pytorch
that referenced
this pull request
Mar 31, 2023
… in transformers" Summary: When we bump up the torchbench version pin last time, we found there were new graph breaks introduced with the trasformers version upgrade, see #96782. Turns out they are already fixed upstream, see huggingface/transformers#21648 and pytorch/benchmark#1511 cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx [ghstack-poisoned]
desertfire
added a commit
to pytorch/pytorch
that referenced
this pull request
Mar 31, 2023
…rmers Summary: When we bump up the torchbench version pin last time, we found there were new graph breaks introduced with the trasformers version upgrade, see #96782. Turns out they are already fixed upstream, see huggingface/transformers#21648 and pytorch/benchmark#1511 ghstack-source-id: 015d2f0 Pull Request resolved: #98003
desertfire
added a commit
to pytorch/pytorch
that referenced
this pull request
Mar 31, 2023
…amo graph breaks in transformers" Summary: When we bump up the torchbench version pin last time, we found there were new graph breaks introduced with the trasformers version upgrade, see #96782. Turns out they are already fixed upstream, see huggingface/transformers#21648 and pytorch/benchmark#1511 cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx [ghstack-poisoned]
desertfire
added a commit
to pytorch/pytorch
that referenced
this pull request
Mar 31, 2023
… in transformers" Summary: When we bump up the torchbench version pin last time, we found there were new graph breaks introduced with the trasformers version upgrade, see #96782. Turns out they are already fixed upstream, see huggingface/transformers#21648 and pytorch/benchmark#1511 cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx [ghstack-poisoned]
desertfire
added a commit
to pytorch/pytorch
that referenced
this pull request
Mar 31, 2023
…amo graph breaks in transformers" Summary: When we bump up the torchbench version pin last time, we found there were new graph breaks introduced with the trasformers version upgrade, see #96782. Turns out they are already fixed upstream, see huggingface/transformers#21648 and pytorch/benchmark#1511 cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx [ghstack-poisoned]
desertfire
added a commit
to pytorch/pytorch
that referenced
this pull request
Mar 31, 2023
… in transformers" Summary: When we bump up the torchbench version pin last time, we found there were new graph breaks introduced with the trasformers version upgrade, see #96782. Turns out they are already fixed upstream, see huggingface/transformers#21648 and pytorch/benchmark#1511 cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx [ghstack-poisoned]
desertfire
added a commit
to pytorch/pytorch
that referenced
this pull request
Mar 31, 2023
…rmers Summary: When we bump up the torchbench version pin last time, we found there were new graph breaks introduced with the trasformers version upgrade, see #96782. Turns out they are already fixed upstream, see huggingface/transformers#21648 and pytorch/benchmark#1511 ghstack-source-id: 48bc749 Pull Request resolved: #98003
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 31, 2023
…rmers (#98003) Summary: When we bump up the torchbench version pin last time, we found there were new graph breaks introduced with the trasformers version upgrade, see #96782. Turns out they are already fixed upstream, see huggingface/transformers#21648 and pytorch/benchmark#1511 Pull Request resolved: #98003 Approved by: https://github.com/ngimel
cclauss
pushed a commit
to cclauss/benchmark
that referenced
this pull request
Jan 22, 2025
* Include the benchmark's family-name in State For compat with internal library, where State::name() returns the benchmark's family name. * added missing files from prev commit * fix field-init order error * added test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: To pick up a torchdynamo graph break fix in transformers, see huggingface/transformers#21648