Skip to content

Conversation

desertfire
Copy link
Contributor

Summary: To pick up a torchdynamo graph break fix in transformers, see huggingface/transformers#21648

Summary: To pick up a torchdynamo graph break fix in transformers, see huggingface/transformers#21648
Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@xuzhao9
Copy link
Contributor

xuzhao9 commented Mar 30, 2023

Current CI errors are because of broken torchtext nightly build: #1504

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in 159e58f.

desertfire added a commit to pytorch/pytorch that referenced this pull request Mar 30, 2023
…rmers

Summary: When we bump up the torchbench version pin last time, we found
there were new graph breaks introduced with the trasformers version
upgrade, see #96782. Turns out
they are already fixed upstream, see
huggingface/transformers#21648 and pytorch/benchmark#1511

[ghstack-poisoned]
desertfire added a commit to pytorch/pytorch that referenced this pull request Mar 30, 2023
…rmers

Summary: When we bump up the torchbench version pin last time, we found
there were new graph breaks introduced with the trasformers version
upgrade, see #96782. Turns out
they are already fixed upstream, see
huggingface/transformers#21648 and pytorch/benchmark#1511

ghstack-source-id: 8f2f284
Pull Request resolved: #98003
desertfire added a commit to pytorch/pytorch that referenced this pull request Mar 30, 2023
… in transformers"

Summary: When we bump up the torchbench version pin last time, we found
there were new graph breaks introduced with the trasformers version
upgrade, see #96782. Turns out
they are already fixed upstream, see
huggingface/transformers#21648 and pytorch/benchmark#1511

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx

[ghstack-poisoned]
desertfire added a commit to pytorch/pytorch that referenced this pull request Mar 30, 2023
…rmers

Summary: When we bump up the torchbench version pin last time, we found
there were new graph breaks introduced with the trasformers version
upgrade, see #96782. Turns out
they are already fixed upstream, see
huggingface/transformers#21648 and pytorch/benchmark#1511

ghstack-source-id: 05fe5d6
Pull Request resolved: #98003
desertfire added a commit to pytorch/pytorch that referenced this pull request Mar 31, 2023
…amo graph breaks in transformers"

Summary: When we bump up the torchbench version pin last time, we found
there were new graph breaks introduced with the trasformers version
upgrade, see #96782. Turns out
they are already fixed upstream, see
huggingface/transformers#21648 and pytorch/benchmark#1511

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx

[ghstack-poisoned]
desertfire added a commit to pytorch/pytorch that referenced this pull request Mar 31, 2023
… in transformers"

Summary: When we bump up the torchbench version pin last time, we found
there were new graph breaks introduced with the trasformers version
upgrade, see #96782. Turns out
they are already fixed upstream, see
huggingface/transformers#21648 and pytorch/benchmark#1511

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx

[ghstack-poisoned]
desertfire added a commit to pytorch/pytorch that referenced this pull request Mar 31, 2023
…rmers

Summary: When we bump up the torchbench version pin last time, we found
there were new graph breaks introduced with the trasformers version
upgrade, see #96782. Turns out
they are already fixed upstream, see
huggingface/transformers#21648 and pytorch/benchmark#1511

ghstack-source-id: 015d2f0
Pull Request resolved: #98003
desertfire added a commit to pytorch/pytorch that referenced this pull request Mar 31, 2023
…amo graph breaks in transformers"

Summary: When we bump up the torchbench version pin last time, we found
there were new graph breaks introduced with the trasformers version
upgrade, see #96782. Turns out
they are already fixed upstream, see
huggingface/transformers#21648 and pytorch/benchmark#1511

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx

[ghstack-poisoned]
desertfire added a commit to pytorch/pytorch that referenced this pull request Mar 31, 2023
… in transformers"

Summary: When we bump up the torchbench version pin last time, we found
there were new graph breaks introduced with the trasformers version
upgrade, see #96782. Turns out
they are already fixed upstream, see
huggingface/transformers#21648 and pytorch/benchmark#1511

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx

[ghstack-poisoned]
desertfire added a commit to pytorch/pytorch that referenced this pull request Mar 31, 2023
…amo graph breaks in transformers"

Summary: When we bump up the torchbench version pin last time, we found
there were new graph breaks introduced with the trasformers version
upgrade, see #96782. Turns out
they are already fixed upstream, see
huggingface/transformers#21648 and pytorch/benchmark#1511

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx

[ghstack-poisoned]
desertfire added a commit to pytorch/pytorch that referenced this pull request Mar 31, 2023
… in transformers"

Summary: When we bump up the torchbench version pin last time, we found
there were new graph breaks introduced with the trasformers version
upgrade, see #96782. Turns out
they are already fixed upstream, see
huggingface/transformers#21648 and pytorch/benchmark#1511

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx

[ghstack-poisoned]
desertfire added a commit to pytorch/pytorch that referenced this pull request Mar 31, 2023
…rmers

Summary: When we bump up the torchbench version pin last time, we found
there were new graph breaks introduced with the trasformers version
upgrade, see #96782. Turns out
they are already fixed upstream, see
huggingface/transformers#21648 and pytorch/benchmark#1511

ghstack-source-id: 48bc749
Pull Request resolved: #98003
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Mar 31, 2023
…rmers (#98003)

Summary: When we bump up the torchbench version pin last time, we found
there were new graph breaks introduced with the trasformers version
upgrade, see #96782. Turns out
they are already fixed upstream, see
huggingface/transformers#21648 and pytorch/benchmark#1511

Pull Request resolved: #98003
Approved by: https://github.com/ngimel
@desertfire desertfire deleted the desertfire/transformers_update branch November 27, 2023 16:35
cclauss pushed a commit to cclauss/benchmark that referenced this pull request Jan 22, 2025
* Include the benchmark's family-name in State

For compat with internal library, where State::name() returns the benchmark's family name.

* added missing files from prev commit

* fix field-init order error

* added test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants