all the llamas in canary #1803
Closed
all the llamas in canary #1803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msaroufim has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
H-Huang
approved these changes
Aug 2, 2023
| @@ -0,0 +1,15 @@ | |||
| from torchbenchmark.tasks import NLP | |||
There was a problem hiding this comment.
just curious, these models are in canary_models as opposed to models dir. Does this effect how these models are pulled in either from torchbench or dyanmorunner and if so in what way?
There was a problem hiding this comment.
This error message explains it super well, should be no difference
File "/var/lib/jenkins/workspace/benchmarks/dynamo/torchbench.py", line 302, in load_model
raise ImportError(f"could not import any of {candidates}")
ImportError: could not import any of ['torchbenchmark.models.stable_diffusion', 'torchbenchmark.canary_models.stable_diffusion', 'torchbenchmark.models.fb.stable_diffusion']
ERROR
|
@msaroufim merged this pull request in e7ca300. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Aug 3, 2023
Includes stable diffusion, whisper, llama7b and clip To get this to work I had to Pass in hf auth token to all ci jobs, github does not pass in secrets from parent to child automatically. There's a likelihood HF will rate limit us in case please revert this PR and I'll work on adding a cache next - cc @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @aakhundov @malfet Something upstream changed in torchbench too where now `hf_Bert` and `hf_Bert_large` are both failing on some dynamic shape looking error which I'm not sure how to debug yet so for now felt a bit gross but added a skip since others are building on top this work @ezyang `llamav2_7b_16h` cannot pass through accuracy checks cause it OOMs on deepcloning extra inputs this seems to make it not need to show up in expected numbers csv, will figure this when we update the pin with pytorch/benchmark#1803 cc @H-Huang @xuzhao9 @cpuhrsch Pull Request resolved: #106009 Approved by: https://github.com/malfet
cclauss
pushed a commit
to cclauss/benchmark
that referenced
this pull request
Jan 22, 2025
When using `includes`, consumers will apply the headers using `-isystem`, instead of `-I`. This will allow diagnostics of consumers to not apply to `benchmark`. More info: https://bazel.build/reference/be/c-cpp#cc_library.includes https://bazel.build/reference/be/c-cpp#cc_library.strip_include_prefix gtest uses `includes` as well: https://github.com/google/googletest/blob/1d17ea141d2c11b8917d2c7d029f1c4e2b9769b2/BUILD.bazel#L120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these OOM on a single device but want to make them all available for the distributed tests @H-Huang is working on