Skip to content

Conversation

mjanderson09
Copy link

Reviewed By: xuzhao9

Differential Revision: D48523883

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48523883

@mjanderson09 mjanderson09 temporarily deployed to docker-s3-upload August 28, 2023 05:22 — with GitHub Actions Inactive
@mjanderson09 mjanderson09 temporarily deployed to docker-s3-upload August 28, 2023 05:22 — with GitHub Actions Inactive
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48523883

mjanderson09 added a commit to mjanderson09/benchmark that referenced this pull request Aug 28, 2023
…ytorch#1856)

Summary:
X-link: pytorch/pytorch#108037

Pull Request resolved: pytorch#1856

Reviewed By: xuzhao9

Differential Revision: D48523883

fbshipit-source-id: 90367dc96a14791f1ffb318cf7f288aa81cd759b
@mjanderson09 mjanderson09 temporarily deployed to docker-s3-upload August 28, 2023 17:50 — with GitHub Actions Inactive
@mjanderson09 mjanderson09 temporarily deployed to docker-s3-upload August 28, 2023 17:51 — with GitHub Actions Inactive
mjanderson09 added a commit to mjanderson09/pytorch that referenced this pull request Aug 28, 2023
…ytorch#108037)

Summary:
Pull Request resolved: pytorch#108037

X-link: pytorch/benchmark#1856

Reviewed By: xuzhao9

Differential Revision: D48523883

fbshipit-source-id: 6db0507431cf367349e13073ffd90197be0a0e57
Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48523883

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48523883

mjanderson09 added a commit to mjanderson09/pytorch that referenced this pull request Sep 5, 2023
mjanderson09 added a commit to mjanderson09/benchmark that referenced this pull request Sep 5, 2023
…ytorch#1856)

Summary:
X-link: pytorch/pytorch#108037


Reviewed By: xuzhao9

Differential Revision: D48523883
mjanderson09 added a commit to mjanderson09/benchmark that referenced this pull request Sep 5, 2023
…ytorch#1856)

Summary:
X-link: pytorch/pytorch#108037


Reviewed By: xuzhao9

Differential Revision: D48523883
@mjanderson09 mjanderson09 temporarily deployed to docker-s3-upload September 5, 2023 16:48 — with GitHub Actions Inactive
@mjanderson09 mjanderson09 temporarily deployed to docker-s3-upload September 5, 2023 16:48 — with GitHub Actions Inactive
mjanderson09 added a commit to mjanderson09/benchmark that referenced this pull request Sep 5, 2023
…ytorch#1856)

Summary:
X-link: pytorch/pytorch#108037


Reviewed By: xuzhao9

Differential Revision: D48523883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48523883

mjanderson09 added a commit to mjanderson09/benchmark that referenced this pull request Sep 5, 2023
…ytorch#1856)

Summary:
X-link: pytorch/pytorch#108037


Reviewed By: xuzhao9

Differential Revision: D48523883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48523883

@mjanderson09 mjanderson09 temporarily deployed to docker-s3-upload September 9, 2023 19:11 — with GitHub Actions Inactive
@mjanderson09 mjanderson09 temporarily deployed to docker-s3-upload September 9, 2023 19:11 — with GitHub Actions Inactive
mjanderson09 added a commit to mjanderson09/benchmark that referenced this pull request Sep 10, 2023
…ytorch#1856)

Summary:
X-link: pytorch/pytorch#108037


Reviewed By: xmfan, xuzhao9

Differential Revision: D48523883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48523883

mjanderson09 added a commit to mjanderson09/benchmark that referenced this pull request Sep 10, 2023
…ytorch#1856)

Summary:
X-link: pytorch/pytorch#108037


Reviewed By: xmfan, xuzhao9

Differential Revision: D48523883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48523883

@mjanderson09 mjanderson09 temporarily deployed to docker-s3-upload September 10, 2023 00:52 — with GitHub Actions Inactive
@mjanderson09 mjanderson09 temporarily deployed to docker-s3-upload September 10, 2023 00:53 — with GitHub Actions Inactive
…ytorch#1856)

Summary:
X-link: pytorch/pytorch#108037


Reviewed By: xmfan, xuzhao9

Differential Revision: D48523883
mjanderson09 added a commit to mjanderson09/benchmark that referenced this pull request Sep 10, 2023
…ytorch#1856)

Summary:
X-link: pytorch/pytorch#108037


Reviewed By: xmfan, xuzhao9

Differential Revision: D48523883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48523883

mjanderson09 added a commit to mjanderson09/pytorch that referenced this pull request Sep 10, 2023
…ytorch#108037)

Summary:

X-link: pytorch/benchmark#1856

Reviewed By: xmfan, xuzhao9

Differential Revision: D48523883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48523883

@mjanderson09 mjanderson09 temporarily deployed to docker-s3-upload September 10, 2023 15:57 — with GitHub Actions Inactive
levythu pushed a commit to levythu/pytorch that referenced this pull request Sep 11, 2023
…ytorch#108037)

Summary:

X-link: pytorch/benchmark#1856

Reviewed By: xmfan, xuzhao9

Differential Revision: D48523883
levythu pushed a commit to levythu/benchmark that referenced this pull request Sep 11, 2023
…ytorch#1856)

Summary:
X-link: pytorch/pytorch#109076

X-link: pytorch/pytorch#108037


Reviewed By: xmfan, xuzhao9

Differential Revision: D48523883
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Oct 3, 2023
…108037) (#109076)

Summary:

X-link: pytorch/benchmark#1856

Reviewed By: xmfan, xuzhao9

Differential Revision: D48523883

Pull Request resolved: #109076
Approved by: https://github.com/xw285cornell
@xuzhao9
Copy link
Contributor

xuzhao9 commented Oct 4, 2023

Closed by #1951

@xuzhao9 xuzhao9 closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants