Cleanup the code in the dynamo userbenchmark
#1960
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
force-pushed
the
xz9/cleanup-dynamo
branch
from
7d07af8 to
454b701
Compare
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
I am not familiar with this part of code. What are we trying to achieve here? If you just need a stamp, I can do that. |
Summary: Skip importing the modules that are only available in the pytorch source code, not pytorch nightly release. Make dynamo benchmark work on both OSS and internal. Test Plan: ``` $ python run_benchmark.py dynamo --only alexnet --training --performance --inductor loading model: 0it [00:05, ?it/s] cuda train alexnet running benchmark: 100%|█████████████████| 30/30 [00:00<00:00, 41.46it/s] 1.129x ``` ``` $ buck2 run mode/opt //pytorch/benchmark:run_benchmark -- dynamo --only alexnet --training --inductor --performance --output-directory $HOME loading model: 0it [00:16, ?it/s] running benchmark: 100%|█████████████████| 30/30 [00:00<00:00, 37.94it/s] cuda train alexnet 1.120x ``` Differential Revision: D49912006 Pulled By: xuzhao9
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Oct 4, 2023
Summary: Skip importing the modules that are only available in the pytorch source code, not pytorch nightly release. Make dynamo benchmark work on both OSS and internal. X-link: pytorch/benchmark#1960 Test Plan: ``` $ python run_benchmark.py dynamo --only alexnet --training --performance --inductor loading model: 0it [00:05, ?it/s] cuda train alexnet running benchmark: 100%|█████████████████| 30/30 [00:00<00:00, 41.46it/s] 1.129x ``` ``` $ buck2 run mode/opt //pytorch/benchmark:run_benchmark -- dynamo --only alexnet --training --inductor --performance --output-directory $HOME loading model: 0it [00:16, ?it/s] running benchmark: 100%|█████████████████| 30/30 [00:00<00:00, 37.94it/s] cuda train alexnet 1.120x ``` Differential Revision: D49912006 Pulled By: xuzhao9
|
This pull request was exported from Phabricator. Differential Revision: D49912006 |
facebook-github-bot
force-pushed
the
xz9/cleanup-dynamo
branch
from
0741ef3 to
1ecde79
Compare
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
facebook-github-bot
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
@desertfire This would be the first step towards applying the torchbench bisector on dynamo bench. |
desertfire
approved these changes
Oct 4, 2023
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Oct 4, 2023
Summary: Skip importing the modules that are only available in the pytorch source code, not pytorch nightly release. Make dynamo benchmark work on both OSS and internal. X-link: pytorch/benchmark#1960 Test Plan: ``` $ python run_benchmark.py dynamo --only alexnet --training --performance --inductor loading model: 0it [00:05, ?it/s] cuda train alexnet running benchmark: 100%|█████████████████| 30/30 [00:00<00:00, 41.46it/s] 1.129x ``` ``` $ buck2 run mode/opt //pytorch/benchmark:run_benchmark -- dynamo --only alexnet --training --inductor --performance --output-directory $HOME loading model: 0it [00:16, ?it/s] running benchmark: 100%|█████████████████| 30/30 [00:00<00:00, 37.94it/s] cuda train alexnet 1.120x ``` Reviewed By: desertfire Differential Revision: D49912006 Pulled By: xuzhao9
xuzhao9
added a commit
to pytorch/pytorch
that referenced
this pull request
Oct 4, 2023
Summary: Skip importing the modules that are only available in the pytorch source code, not pytorch nightly release. Make dynamo benchmark work on both OSS and internal. X-link: pytorch/benchmark#1960 Test Plan: ``` $ python run_benchmark.py dynamo --only alexnet --training --performance --inductor loading model: 0it [00:05, ?it/s] cuda train alexnet running benchmark: 100%|█████████████████| 30/30 [00:00<00:00, 41.46it/s] 1.129x ``` ``` $ buck2 run mode/opt //pytorch/benchmark:run_benchmark -- dynamo --only alexnet --training --inductor --performance --output-directory $HOME loading model: 0it [00:16, ?it/s] running benchmark: 100%|█████████████████| 30/30 [00:00<00:00, 37.94it/s] cuda train alexnet 1.120x ``` Reviewed By: desertfire Differential Revision: D49912006 Pulled By: xuzhao9
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Oct 4, 2023
Summary: Skip importing the modules that are only available in the pytorch source code, not pytorch nightly release. Make dynamo benchmark work on both OSS and internal. X-link: pytorch/benchmark#1960 Test Plan: ``` $ python run_benchmark.py dynamo --only alexnet --training --performance --inductor loading model: 0it [00:05, ?it/s] cuda train alexnet running benchmark: 100%|█████████████████| 30/30 [00:00<00:00, 41.46it/s] 1.129x ``` ``` $ buck2 run mode/opt //pytorch/benchmark:run_benchmark -- dynamo --only alexnet --training --inductor --performance --output-directory $HOME loading model: 0it [00:16, ?it/s] running benchmark: 100%|█████████████████| 30/30 [00:00<00:00, 37.94it/s] cuda train alexnet 1.120x ``` Differential Revision: D49912006 Pulled By: xuzhao9 Pull Request resolved: #110519 Approved by: https://github.com/desertfire, https://github.com/jansel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip importing the modules that are only available in the pytorch source code, not pytorch nightly release.
Test plan: