Add PyTorch PR CI support #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wconstab
reviewed
Apr 27, 2021
| if not repo_origin_url == TORCHBENCH_GITREPO: | ||
| print(f"WARNING: Unmatched repo origin url: {repo_origin_url} with standard {TORCHBENCH_GITREPO}") | ||
| # get list of models | ||
| self.models = [ model for model in os.listdir(os.path.join(self.srcpath, "torchbenchmark", "models")) |
There was a problem hiding this comment.
any reason to do this instead of importing 'list_models' function from torchbenchmark?
There was a problem hiding this comment.
This function is called in prepartion, when the pytorch/torchvision/torchtext packages are not built and installed yet (they are installed later when actually running the bisection/abtesting). Therefore, the list_models function doesn't work at this point.
wconstab
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add TorchBench support in PyTorch CI.
It modifies bisection.py so that the bisector is also able to run abtests.
It also allows users to specify model names as test items. So model names like "yolov3" also works, not just "test_eval[yolov3-cpu-eager]".
This PR is the prerequisite of the TorchBench CI PR on PyTorch: pytorch/pytorch#56957.