[ROCm] add dependencies for rocm5.2 #1033
Conversation
|
Also, before we merge this, can we verify it passes CI? |
It's the latest ROCm version that was released. We always strive to keep the nightly binary builds on the latest ROCm release. |
I think the ROCm CI builds already passed. |
|
@janeyx99 Please let us know if we need something more in this PR to merge it. The pytorchbot command doesn't work on builder repo I think. |
|
merged |
Corresponding builder PR: pytorch/builder#1033
|
@janeyx99 On the corresponding pytorch PR I'm getting build failures for rocm 5.2 binaries because the docker image is missing. pytorch/manylinux-builder:rocm5.2 How can we trigger a build and push of this image? I thought this current PR should have done that. |
|
@jeffdaily it looks liek the corresponding actions timed out https://github.com/pytorch/builder/actions/runs/2733195759 |
Looks like rocm base image builds need more time. Can we increase the timeout? We need these images for nightly pytorch binaries. |
|
@janeyx99 but the latest CI runs were all successful. Not sure why they timed out for the run you linked to. https://github.com/pytorch/builder/pull/1033/checks?check_run_id=7201495074 |
Corresponding builder PR: pytorch/builder#1033
Corresponding builder PR: pytorch/builder#1033
### Description Updates ROCm arches for nightly binaries to 5.1.1 and 5.2, dropping 5.0. Corresponding builder PR: pytorch/builder#1033 ### Testing PR CI with extra label to enable binary builds. Pull Request resolved: #82353 Approved by: https://github.com/janeyx99, https://github.com/malfet
### Description Updates ROCm arches for nightly binaries to 5.1.1 and 5.2, dropping 5.0. Corresponding builder PR: pytorch/builder#1033 ### Testing PR CI with extra label to enable binary builds. Pull Request resolved: #82353 Approved by: https://github.com/janeyx99, https://github.com/malfet
Summary: ### Description Updates ROCm arches for nightly binaries to 5.1.1 and 5.2, dropping 5.0. Corresponding builder PR: pytorch/builder#1033 ### Testing PR CI with extra label to enable binary builds. Pull Request resolved: #82353 Approved by: https://github.com/janeyx99, https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/2dae93b212de21b2dafc76327ba9c5ac90fa6be6 Reviewed By: seemethere Differential Revision: D38624007 fbshipit-source-id: e52f7e7e0a307cac0becd26cd55984481ca6b12f
4 participants
No description provided.