This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Following practice of pinning cmake where conda is used #1269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From this PR #1011 I saw there are files using conda here that don't have cmake pinned to 3.22.*. Shall we pin them?
Context (why pin cmake to 3.22.*?)
When conda offered cmake version 3.23.0, certain builds would break pytorch/pytorch#74985 (comment). This resulted in the pinning of cmake to a stable version like 3.22 where conda is used pytorch/benchmark#845. Since then, conda has yanked 3.23.0 and is currently on version 3.22.1, so it was then safe to unpin cmake pytorch/pytorch#75705.
Now, it has been decided that it would be best practice to pin cmake to a known stable version, then upgrade in a controlled manner instead of leaving cmake unpinned pytorch/pytorch#91739 (comment). Initially set to 3.22, it has since been relaxed to 3.22.* pytorch/pytorch#90307. We've already pinned cmake to 3.22.* in pytorch/pytorch here pytorch/pytorch#91739 and pytorch/test-infra here pytorch/test-infra#1368.
How is this Tested?
I attempted to follow these instructions to test these changes. The fake PR can be found here pytorch/pytorch#92590.
People with Relevant Context
@huydhn @janeyx99