This repository was archived by the owner on Aug 15, 2025. It is now read-only.
[Release 2.5] Inject triton 3.1.0 into staged for pypi dependency for linux aarch64 builds #2011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit1980
approved these changes
Oct 15, 2024
atalman
changed the title
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Oct 22, 2024
Aarch64 builds skipped the logic of sourcing binary env file. And as a result PYTORCH_EXTRA_INSTALL_REQUIREMENTS passed to Aarch64 builds have not included triton dependency constraint. This PR makes sure Aarch64 builds follow same path as our regular manywheel builds. To work around this issue we had to inject triton in aarrch64 builds for release 2.5, which is not ideal: pytorch/builder#2011 Pull Request resolved: #138588 Approved by: https://github.com/jeanschmidt, https://github.com/malfet
SamGinzburg
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Oct 28, 2024
Aarch64 builds skipped the logic of sourcing binary env file. And as a result PYTORCH_EXTRA_INSTALL_REQUIREMENTS passed to Aarch64 builds have not included triton dependency constraint. This PR makes sure Aarch64 builds follow same path as our regular manywheel builds. To work around this issue we had to inject triton in aarrch64 builds for release 2.5, which is not ideal: pytorch/builder#2011 Pull Request resolved: #138588 Approved by: https://github.com/jeanschmidt, https://github.com/malfet
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Injects triton 3.1.0 into staged for pypi dependency for linux aarch64 builds