This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Enable AArch64 CI scripts to be used for local dev #2028
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If conda has already been set up, activate rather than rerunning aarch64_ci_setup.sh - Allow user to specify custom ComputeLibrary directory, which is then built rather than checking out a clean copy - Remove `setup.py clean` in build. The CI environment should be clean already, removing this enables incremental rebuilds - Use all cores for building ComputeLibrary Co-authored-by: David Svantesson-Yeung <David.Svantesson-Yeung@arm.com> Co-authored-by: Fadi Arafeh <Fadi.Arafeh@arm.com>
|
Hi @jondea! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
@jondea you'll need to sign CLA before I can review your change |
|
@jondea scripts has been moved to |
|
Thanks for taking a look @malfet, I appreciate the insight. Is there somewhere I can read about what goes in this repo and what goes in the main pytorch repo? I'm not clear on the distinction, sorry. Also, if the ci build scripts are now in the main repo, should these scripts/directory be deleted? |
|
I've just found #2030! Ignore my last comment |
jondea
added a commit
to jondea/pytorch
that referenced
this pull request
Jan 3, 2025
- Allow user to specify custom ComputeLibrary directory, which is then built rather than checking out a clean copy - Remove `setup.py clean` in build. The CI environment should be clean already, removing this enables incremental rebuilds - Use all cores for building ComputeLibrary - Remove restriction of building with MAX_JOBS=5 on CPU backend Mostly a port of pytorch/builder#2028 with the conda part removed, because aarch64_ci_setup.sh has changed and can now handle being called twice. Co-authored-by: David Svantesson-Yeung <David.Svantesson-Yeung@arm.com> Co-authored-by: Fadi Arafeh <Fadi.Arafeh@arm.com>
jondea
added a commit
to jondea/pytorch
that referenced
this pull request
Feb 25, 2025
- Allow user to specify a custom Arm Compute Library directory with the ACL_SOURCE_DIR environment variable, which is then built rather than checking out a clean copy - Remove `setup.py clean` in build. The CI environment should be clean already, removing this enables incremental rebuilds - Use all cores for building ComputeLibrary - Remove restriction of building with MAX_JOBS=5 on CPU backend Mostly a port of pytorch/builder#2028 with the conda part removed, because aarch64_ci_setup.sh has changed and can now handle being called twice. Co-authored-by: David Svantesson-Yeung <David.Svantesson-Yeung@arm.com> Co-authored-by: Fadi Arafeh <Fadi.Arafeh@arm.com>
pytorchmergebot
pushed a commit
to jondea/pytorch
that referenced
this pull request
Apr 30, 2025
- Allow user to specify a custom Arm Compute Library directory with the ACL_SOURCE_DIR environment variable, which is then built rather than checking out a clean copy - Remove `setup.py clean` in build. The CI environment should be clean already, removing this enables incremental rebuilds - Use all cores for building ComputeLibrary - Remove restriction of building with MAX_JOBS=5 on CPU backend Mostly a port of pytorch/builder#2028 with the conda part removed, because aarch64_ci_setup.sh has changed and can now handle being called twice. Co-authored-by: David Svantesson-Yeung <David.Svantesson-Yeung@arm.com> Co-authored-by: Fadi Arafeh <Fadi.Arafeh@arm.com>
pytorchmergebot
pushed a commit
to jondea/pytorch
that referenced
this pull request
May 15, 2025
- Allow user to specify a custom Arm Compute Library directory with the ACL_SOURCE_DIR environment variable, which is then built rather than checking out a clean copy - Remove `setup.py clean` in build. The CI environment should be clean already, removing this enables incremental rebuilds - Use all cores for building ComputeLibrary - Remove restriction of building with MAX_JOBS=5 on CPU backend Mostly a port of pytorch/builder#2028 with the conda part removed, because aarch64_ci_setup.sh has changed and can now handle being called twice. Co-authored-by: David Svantesson-Yeung <David.Svantesson-Yeung@arm.com> Co-authored-by: Fadi Arafeh <Fadi.Arafeh@arm.com>
jondea
added a commit
to jondea/pytorch
that referenced
this pull request
May 22, 2025
- Allow user to specify a custom Arm Compute Library directory with the ACL_SOURCE_DIR environment variable, which is then built rather than checking out a clean copy - Remove `setup.py clean` in build. The CI environment should be clean already, removing this enables incremental rebuilds - Use all cores for building ComputeLibrary - Remove restriction of building with MAX_JOBS=5 on CPU backend Mostly a port of pytorch/builder#2028 with the conda part removed, because aarch64_ci_setup.sh has changed and can now handle being called twice. Co-authored-by: David Svantesson-Yeung <David.Svantesson-Yeung@arm.com> Co-authored-by: Fadi Arafeh <Fadi.Arafeh@arm.com>
pytorch-bot bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
May 23, 2025
- Allow user to specify a custom Arm Compute Library directory with the ACL_SOURCE_DIR environment variable, which is then built rather than checking out a clean copy - Remove `setup.py clean` in build. The CI environment should be clean already, removing this enables incremental rebuilds - Use all cores for building ComputeLibrary - Remove restriction of building with MAX_JOBS=5 on CPU backend Mostly a port of pytorch/builder#2028 with the conda part removed, because aarch64_ci_setup.sh has changed and can now handle being called twice. Co-authored-by: David Svantesson-Yeung <David.Svantesson-Yeung@arm.com> Co-authored-by: Fadi Arafeh <Fadi.Arafeh@arm.com>
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
May 23, 2025
- Allow user to specify custom ComputeLibrary directory, which is then built rather than checking out a clean copy - Remove `setup.py clean` in build. The CI environment should be clean already, removing this enables incremental rebuilds - Use all cores for building ComputeLibrary Mostly a port of pytorch/builder#2028 with the conda part removed, because aarch64_ci_setup.sh has changed and can now handle being called twice. Pull Request resolved: #143190 Approved by: https://github.com/aditew01, https://github.com/fadara01, https://github.com/malfet Co-authored-by: David Svantesson-Yeung <David.Svantesson-Yeung@arm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.py cleanin build. The CI environment should be clean already, removing this enables incremental rebuilds