Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Conversation

@jithunnair-amd
Copy link
Contributor

Companion to PR pytorch/pytorch#140681

Required for manywheel test jobs to pass for ROCm manylinux2_28 wheels eg. https://github.com/pytorch/pytorch/actions/runs/11924235599/job/33237722860

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 21, 2024

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@jithunnair-amd jithunnair-amd changed the title Expect GCC_ABI=1 for ROCm manylinux2_28 wheels Expect _GLIBCXX_USE_CXX11_ABI=1 for ROCm manylinux2_28 wheels Nov 21, 2024
@jithunnair-amd jithunnair-amd merged commit 5354a64 into pytorch:main Nov 23, 2024
4 checks passed
@jithunnair-amd jithunnair-amd deleted the jnair/rocm_manylinux2_28_upgrade branch November 23, 2024 03:46
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Nov 26, 2024
Fixes #140631

Highlights:
* Use `cpu_final` base for ROCm in `.ci/docker/manywheel/Dockerfile_2_28`
* Cleans up install_miopen.sh to remove old ROCm references
* Install `gcc-gfortran` package to build magma for ROCm on almalinux

Needs builder PR pytorch/builder#2043 (merged) so that GCC_ABI expected value is updated.

Pull Request resolved: #140681
Approved by: https://github.com/jeffdaily
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
…h#140681)

Fixes pytorch#140631

Highlights:
* Use `cpu_final` base for ROCm in `.ci/docker/manywheel/Dockerfile_2_28`
* Cleans up install_miopen.sh to remove old ROCm references
* Install `gcc-gfortran` package to build magma for ROCm on almalinux

Needs builder PR pytorch/builder#2043 (merged) so that GCC_ABI expected value is updated.

Pull Request resolved: pytorch#140681
Approved by: https://github.com/jeffdaily
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants