This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Make it possible to use VS2019 as the compiler in binary jobs #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjc123
commented
May 23, 2020
peterjc123
changed the title
peterjc123
changed the title
|
Please merge after pytorch/pytorch#38957 is landed. cc @soumith @seemethere |
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
May 26, 2020
Summary: To make it configurable in pytorch/builder#445. Pull Request resolved: #38957 Differential Revision: D21721933 Pulled By: ezyang fbshipit-source-id: 510b19e59bed4ff9d6c39173b4d5c5fc69290ed0
malfet
approved these changes
May 26, 2020
malfet
reviewed
May 26, 2020
| $process = Start-Process "${PWD}\vs_installer.exe" -ArgumentList $VS_INSTALL_ARGS -NoNewWindow -Wait -PassThru | ||
| Remove-Item -Path vs_installer.exe -Force | ||
| $exitCode = $process.ExitCode | ||
| if (($exitCode -ne 0) -and ($exitCode -ne 3010)) { |
There was a problem hiding this comment.
Can you please copy VSCollect.exe logic here from https://github.com/pytorch/pytorch/blob/master/.circleci/scripts/vs_install.ps1#L25
And this script is not at all used right now, isn't it?
There was a problem hiding this comment.
There was a problem hiding this comment.
Can you please copy VSCollect.exe logic here from https://github.com/pytorch/pytorch/blob/master/.circleci/scripts/vs_install.ps1#L25
Sound reasonable. Will need to upload them as artifacts in binary jobs,
malfet
reviewed
May 26, 2020
malfet
approved these changes
May 26, 2020
seemethere
approved these changes
May 26, 2020
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
May 26, 2020
Summary: This PR relies on #38957 and pytorch/builder#445. Tested with #38949 and #38956. Will need a rebase after the dependent commits go in Pull Request resolved: #38959 Differential Revision: D21732423 Pulled By: malfet fbshipit-source-id: 50837a026a575bb3d547526e299db7bcfd7637a8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with pytorch/pytorch#38949 and pytorch/pytorch#38956.