This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Add typing_extensions as a new dependency #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See pytorch/pytorch#38221 I removed some py2k and py35 lines, those are no longer supported and it looked to me like cleaning up was better than modifying.
rgommers
added a commit
to rgommers/pytorch
that referenced
this pull request
Aug 2, 2020
Closes pytorchgh-38221. The related pytorch/builder PR: pytorch/builder#475
malfet
approved these changes
Aug 3, 2020
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Aug 4, 2020
Summary: Closes gh-38221. The related pytorch/builder PR: pytorch/builder#475 Pull Request resolved: #42431 Reviewed By: malfet Differential Revision: D22916499 Pulled By: ezyang fbshipit-source-id: c8fe9413b62fc7a6b829fc82aaf32531b55994d1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See pytorch/pytorch#38221
I removed some py2k and py35 lines, those are no longer supported and it looked to me like cleaning up was better than modifying.