Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Conversation

@walterddr
Copy link
Contributor

No description provided.

@walterddr
Copy link
Contributor Author

@jeffdaily @seemethere

@walterddr walterddr closed this Sep 8, 2020
@walterddr walterddr force-pushed the pr/fix_check_binary_rocm branch from b4c4f70 to 99089ea Compare September 8, 2020 16:20
@walterddr walterddr reopened this Sep 8, 2020
@jeffdaily
Copy link
Contributor

The corresponding PR on the pytorch side is pytorch/pytorch#44250. It is failing to run the build_libtorch.sh script because build_amd.py is not run first to hipify the sources.

This log shows a sample failing build:
https://app.circleci.com/pipelines/github/pytorch/pytorch/210639/workflows/72c5caa6-c1dc-4fbc-b092-b95fcac1a3aa/jobs/7276996

Suggested diff for this PR to run the hipify script.

diff --git a/manywheel/build_libtorch.sh b/manywheel/build_libtorch.sh
index ffd56cf..5b392f2 100644
--- a/manywheel/build_libtorch.sh
+++ b/manywheel/build_libtorch.sh
@@ -110,6 +110,11 @@ else
     export _GLIBCXX_USE_CXX11_ABI=0
 fi

+if [[ "$DESIRED_CUDA" == *"rocm"* ]]; then
+    echo "Calling build_amd.py at $(date)"
+    python tools/amd_build/build_amd.py
+fi
+
 echo "Calling setup.py install at $(date)"

 if [[ $LIBTORCH_VARIANT = *"static"* ]]; then

Co-authored-by: Jeff Daily <jeff.daily@amd.com>
@seemethere seemethere merged commit 86e9398 into pytorch:master Sep 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants