This repository was archived by the owner on Aug 15, 2025. It is now read-only.
add ROCm 3.8 manywheel build #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@walterddr please review. Thanks! |
walterddr
approved these changes
Sep 23, 2020
There was a problem hiding this comment.
lgtm. did you also want to add rocm3.8 in https://github.com/pytorch/pytorch/blob/master/.circleci/cimodel/data/dimensions.py#L10-L12 first?
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Sep 24, 2020
Summary: Corresponding change in builder repo: pytorch/builder#528. Pull Request resolved: #45222 Reviewed By: ezyang Differential Revision: D23894831 Pulled By: walterddr fbshipit-source-id: c6a256ec325ddcf5836b4d293f546368d58db538
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.