This repository was archived by the owner on Aug 15, 2025. It is now read-only.
s3_management: Add tools to generate HTML indices for S3 #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malfet
approved these changes
Dec 8, 2020
s3_management/manage.py
Outdated
| ACCEPTED_FILE_EXTENSIONS = ("whl", "zip") | ||
|
|
||
| # How many packages should we keep of a specific package? | ||
| KEEP_THRESHOLD = 20 |
There was a problem hiding this comment.
Can we have a threshold of say 60 days?
malfet
reviewed
Dec 8, 2020
s3_management/prune_nightly.sh
Outdated
Comment on lines
16
to
23
| for pkg in $(cat packages_to_delete); do | ||
| ( | ||
| set -x | ||
| aws s3 rm ${DRY_RUN_FLAG} "${pkg}" | ||
| ) | ||
| done |
There was a problem hiding this comment.
Hmm, why not delete it right from the .py script?
There was a problem hiding this comment.
I wanted to have an option to do a dry run for testing purposes and it turns out that boto3 does not have a dry run option.
There was a problem hiding this comment.
seemethere
force-pushed
the
prune_nightly_wheels
branch
2 times, most recently
from
7499803 to
7a13255
Compare
seemethere
changed the title
seemethere
force-pushed
the
prune_nightly_wheels
branch
4 times, most recently
from
7bc3cc3 to
00a1f18
Compare
Adds tools to generate the S3 HTML files. Also includes a mechanism for limiting the amount of nightly builds that are included in the S3 HTML files so that we don't get needlessly large indices. Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
seemethere
force-pushed
the
prune_nightly_wheels
branch
from
00a1f18 to
b13f7f9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors our S3 HTML index generation script to be written in python and have extra functionality like limiting nightly builds to a specific threshold
Signed-off-by: Eli Uriegas eliuriegas@fb.com