Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Conversation

jeffdaily
Copy link
Contributor

@jeffdaily jeffdaily commented Jan 28, 2021

For ROCm versions 4.0.1 or greater, MIOpen is built from source with the Code Object Manager (COMgr) option enabled (default miopen-hip package has this disabled.) This allows MIOpen to compiling kernels at runtime using COMgr instead of depending on a system call to hipcc or other installed compiler binaries. For wheels, this drop-in MIOpen replacement becomes the bundled library.

@jeffdaily
Copy link
Contributor Author

This PR also revises the many ROCm version if/else condition blocks, simplifying them by using integer comparison. As far as major *.so versions are concerned, very little changes from one release to the next, so much of the logic can be carefully reused from one version to the next.

@jeffdaily
Copy link
Contributor Author

FYI: new docker image for ROCm 4.01 has already been pushed. pytorch/manylinux-rocm:4.0.1

jeffdaily added a commit to ROCm/pytorch that referenced this pull request Jan 28, 2021
@malfet malfet requested a review from seemethere February 1, 2021 21:18
@malfet
Copy link
Contributor

malfet commented Feb 1, 2021

LGTM, but from a quick glance at manywheel/Dockerfile it looks like we always install both CUDA and RoCM into the same docker image. If this is the case, can we please add logic to install either one or the other? (In order to reduce image space)

@jeffdaily
Copy link
Contributor Author

The manywheel/Dockerfile uses docker buildkit (https://docs.docker.com/develop/develop-images/build_enhancements/). CUDA and ROCm will be in the same Dockerfile, sharing what common code makes sense, but will produce distinct images. See the manywheel/deploy.sh for details.

Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also probably take an opportunity to remove some of the older rocm versions we don't build for

@seemethere seemethere merged commit 3efc159 into pytorch:master Feb 1, 2021
facebook-github-bot pushed a commit to pytorch/pytorch that referenced this pull request Feb 3, 2021
Summary:
Depends on pytorch/builder#628.

Pull Request resolved: #51257

Reviewed By: H-Huang, seemethere

Differential Revision: D26208135

Pulled By: malfet

fbshipit-source-id: 8a4386b5661c6f71df28d98279e2771c4044f06c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants