This repository was archived by the owner on Aug 15, 2025. It is now read-only.
conda: Add a way to build singular conda images #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janeyx99
reviewed
Feb 1, 2021
| ADD ./java/jni.h /usr/local/include/jni.h | ||
| ENV PATH /opt/conda/bin:$PATH | ||
| COPY --from=mnist /usr/local/mnist /usr/local/mnist | ||
| RUN rm -rf /usr/local/cuda |
There was a problem hiding this comment.
Why did we need to remove /usr/local/cuda before and do we need to do that after line 73 too?
There was a problem hiding this comment.
it's to remove the original /usr/local/cuda from the base nvidia image
janeyx99
approved these changes
Feb 1, 2021
seemethere
force-pushed
the
singular_conda_images
branch
from
597727b to
c4987f2
Compare
Adds an option to build conda builder images with only one version of CUDA installed effectively reducing image sizes from 20GB+ to ~10GB Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
seemethere
force-pushed
the
singular_conda_images
branch
from
c4987f2 to
f9592c8
Compare
seemethere
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 1, 2021
The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
seemethere
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 2, 2021
The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
seemethere
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 3, 2021
The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
seemethere
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 3, 2021
The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
seemethere
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 3, 2021
The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
seemethere
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 4, 2021
The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
seemethere
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 4, 2021
The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
seemethere
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 4, 2021
The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
seemethere
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 4, 2021
The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
seemethere
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 4, 2021
The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
seemethere
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 4, 2021
The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
seemethere
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 4, 2021
The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
seemethere
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 5, 2021
The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
seemethere
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 5, 2021
The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Differential Revision: [D26281958](https://our.internmc.facebook.com/intern/diff/D26281958) [ghstack-poisoned]
seemethere
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 10, 2021
The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Differential Revision: [D26281958](https://our.internmc.facebook.com/intern/diff/D26281958) [ghstack-poisoned]
seemethere
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 26, 2021
The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Differential Revision: [D26281958](https://our.internmc.facebook.com/intern/diff/D26281958) [ghstack-poisoned]
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Feb 26, 2021
Summary: Pull Request resolved: #51494 The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Test Plan: Imported from OSS Reviewed By: janeyx99 Differential Revision: D26281958 Pulled By: seemethere fbshipit-source-id: 83b498532a6f04801952438537b564f998b62d94
aocsa
pushed a commit
to Quansight/pytorch
that referenced
this pull request
Mar 15, 2021
Summary: Pull Request resolved: pytorch#51494 The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Test Plan: Imported from OSS Reviewed By: janeyx99 Differential Revision: D26281958 Pulled By: seemethere fbshipit-source-id: 83b498532a6f04801952438537b564f998b62d94
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: Pull Request resolved: pytorch#51494 The overall `pytorch/conda-cuda` image was getting to a ridiculous size of 36GB so this splits up that image into cuda specific ones to try and reduce the amount of things we have to download. coincides with: pytorch/builder#634 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Test Plan: Imported from OSS Reviewed By: janeyx99 Differential Revision: D26281958 Pulled By: seemethere fbshipit-source-id: 83b498532a6f04801952438537b564f998b62d94
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to build conda builder images with only one version of
CUDA installed effectively reducing image sizes from 20GB+ to ~10GB
Signed-off-by: Eli Uriegas eliuriegas@fb.com