This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Update MSVC toolchain selection for Windows builds #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix command fix logic Use 19.28 instead fix install args Update VS configuration script Fix vs2019 script Fix env update script Remove double quotes
peterjc123
force-pushed
the
vc_toolset_specify
branch
from
76d6434 to
b91e082
Compare
malfet
approved these changes
Mar 27, 2021
mszhanyi
reviewed
Mar 28, 2021
| if "%VC_YEAR%" == "2019" powershell windows/internal/vs2019_install.ps1 %VC_VERSION% | ||
|
|
||
| set VC_VERSION_LOWER=16 | ||
| set VC_VERSION_UPPER=17 |
There was a problem hiding this comment.
If we don't use VS2017, it'd better to remove them all
There was a problem hiding this comment.
Let's do that in a follow-up PR since this is not the only one spot that involves VS 2017.
seemethere
approved these changes
Mar 28, 2021
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 29, 2021
Summary: Fixes #54502 Needs to be merged after pytorch/builder#684 Pull Request resolved: #54589 Reviewed By: walterddr Differential Revision: D27402066 Pulled By: seemethere fbshipit-source-id: 68f92485d89edf2c3315de8c57447f180679c77d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with pytorch/pytorch#54589.