rm useless code #693
rm useless code #693
Conversation
| set VSDEVCMD_ARGS=-vcvars_ver=%VC_VERSION% | ||
| ) | ||
| if "%VC_YEAR%" == "2017" powershell windows/internal/vs2017_install.ps1 %VC_VERSION% | ||
| if "%VC_YEAR%" == "2019" powershell windows/internal/vs2019_install.ps1 %VC_VERSION% |
There was a problem hiding this comment.
Why did you remove this line?
There was a problem hiding this comment.
- I don't find where is using vc_version for VS2019 now.
- Do we still need VS 2017?
at first, I only wanted to change
if "%VC_YEAR%" == "2019" powershell windows/internal/vs2019_install.ps1 %VC_VERSION%
to
if "%VC_YEAR%" == "2019" powershell windows/internal/vs2019_install.ps1
There was a problem hiding this comment.
The reason is that it's very easy to scrape the lastest VS version but I don't find a way to scrape the matched vc toolchain version in web.
There was a problem hiding this comment.
I mean if you delete this line, then Sorry, looks like I made a mistake here. vs2019_install.ps1 is not executed, is this the correct behaviour?git diff shows a slightly different result from I would expect. And, you are right.
4 participants
remove useless code
same reason as pytorch/pytorch#56230