This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Fixing MAGMA with HIP issues #695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jithunnair-amd @pruthvistony @jeffdaily @sunway513 - please review |
jeffdaily
approved these changes
Apr 22, 2021
jithunnair-amd
approved these changes
Apr 22, 2021
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 23, 2021
Summary: Fixes #55552 * Root-caused issue to MAGMA kernels * Issue is fixed on master of MAGMA MAGMA issue: https://bitbucket.org/icl/magma/issues/43/zgetrf_batched-shfl-kernel-failure-seen-on * Changing PyTorch to use particular commit sha from master of MAGMA project * ~~Reactivating skipped ROCm tests~~ : We will reactivate tests in a different PR Corresponding PyTorch builder PR: pytorch/builder#695 Pull Request resolved: #56448 Reviewed By: seemethere Differential Revision: D27974563 Pulled By: janeyx99 fbshipit-source-id: 25e6f95a20a06d27a5199a623dd7c5db7ca8d6ea
|
@seemethere We have the exact same changes in PR pytorch/pytorch#56448 merged upstream. This PR is to make sure the wheels also have the correct version of Magma built. The only difference from the upstream PR change is the Please merge this PR if it looks okay. |
seemethere
approved these changes
Apr 27, 2021
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Fixes pytorch#55552 * Root-caused issue to MAGMA kernels * Issue is fixed on master of MAGMA MAGMA issue: https://bitbucket.org/icl/magma/issues/43/zgetrf_batched-shfl-kernel-failure-seen-on * Changing PyTorch to use particular commit sha from master of MAGMA project * ~~Reactivating skipped ROCm tests~~ : We will reactivate tests in a different PR Corresponding PyTorch builder PR: pytorch/builder#695 Pull Request resolved: pytorch#56448 Reviewed By: seemethere Differential Revision: D27974563 Pulled By: janeyx99 fbshipit-source-id: 25e6f95a20a06d27a5199a623dd7c5db7ca8d6ea
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pytorch/pytorch#55552
Main PyTorch PR : pytorch/pytorch#56448
MAGMA issue: https://bitbucket.org/icl/magma/issues/43/zgetrf_batched-shfl-kernel-failure-seen-on