This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Skip debug info on PRs #778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gates the debug build behavior behind the `BUILD_DEBUG_INFO` env variable, which is set in `binary_linux_build.sh` in pytorch/pytorch#58897
seemethere
approved these changes
May 25, 2021
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
May 26, 2021
Summary: Pull Request resolved: #58897 We don't need to be building debug info on PRs since it's just filling up S3/CircleCI storage with useless 800 MB zips, this flips it so it's only run on master + release branches. See #58898 for CI signal Also see pytorch/builder counterpart (unlike the last debuginfo PR there is no hard dependency between these two so there won't be any churn on un-rebased PRs): pytorch/builder#778 Test Plan: Imported from OSS Reviewed By: seemethere, samestep Differential Revision: D28689413 Pulled By: driazati fbshipit-source-id: 77a37e84afe492215008d5e023ceab0c24adb33c
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
Summary: Pull Request resolved: pytorch#58897 We don't need to be building debug info on PRs since it's just filling up S3/CircleCI storage with useless 800 MB zips, this flips it so it's only run on master + release branches. See pytorch#58898 for CI signal Also see pytorch/builder counterpart (unlike the last debuginfo PR there is no hard dependency between these two so there won't be any churn on un-rebased PRs): pytorch/builder#778 Test Plan: Imported from OSS Reviewed By: seemethere, samestep Differential Revision: D28689413 Pulled By: driazati fbshipit-source-id: 77a37e84afe492215008d5e023ceab0c24adb33c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gates the debug build behavior behind the
BUILD_DEBUG_INFOenv variable, which is set inbinary_linux_build.shin pytorch/pytorch#58897