This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Removed caffe2 testing in LTS binary builds #890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malfet
suggested changes
Nov 17, 2021
There was a problem hiding this comment.
Hmm, this looks like a functional change to me, which should not be allowed in LTS branch - Caffe2 support will be removed starting from PyTorch-1.11, but is still present in 1.10 and definitely were present at the time of 1.8 release? So why do you want to disable it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR carries over the changes done in PR #864, which removes the caffe2 import tests. This is causing the LTS binary builds to fail, due to it perceiving a missing NumPy package. Sample failure link.