Adjust log levels of /proc/cpuinfo parsing #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Review: @malfet |
fbarchard
approved these changes
Nov 30, 2023
Collaborator
fbarchard
left a comment
fbarchard
left a comment
There was a problem hiding this comment.
thanks... these messages are not very interesting, so reducing it is a good idea
malfet
reviewed
Jan 6, 2024
prashanthswami
force-pushed
the
adjust-log-level
branch
3 times, most recently
from
cd7de52 to
9104dce
Compare
There are a few steps in our parsing logic where we skip lines that don't match the expectations of the /proc/cpuinfo node. Reduce the log level of these lines to 'debug', as these are not generally errors and are noisy on systems that have unique cpuinfo key-value pairs. When parsing logic encounters a higher-than-expected processor number, increase the level to warning, to indicate that an error may have occurred in the parsing step.
prashanthswami
force-pushed
the
adjust-log-level
branch
from
9104dce to
cc93df1
Compare
malfet
approved these changes
Jan 8, 2024
Contributor
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
Thank you for the updates, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few steps in our parsing logic where we skip lines that don't match the expectations of the /proc/cpuinfo node. Reduce the log level of these lines to 'debug', as these are not generally errors and are noisy on systems that have unique cpuinfo key-value pairs.
When parsing logic encounters a higher-than-expected processor number, increase the level to warning, to indicate that an error may have occurred in the parsing step.
This does not fully address #19 but resolves the underlying noise reported.