Update cpuinfo to support AVX10.2 ISA detection #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the version for the AVX 10 in this case we are testing for AVX 10.2 but it covers the whole 8 bits.
added comments to AVX 10 detection for both AVX10.1 and AVX10.2
fbarchard
reviewed
Jan 31, 2025
src/x86/isa.c
Outdated
| * AVX 10.2 instructions: avx 10 version information. | ||
| * - Intel: ebx[bits 0-7] in structured features info (eax = 24 ecx = 0). | ||
| */ | ||
| isa.avx10_2 = !!((structured_feature_info2.ebx & UINT32_C(0x000000FF)) >= 2) && isa.avx10_1; |
Collaborator
There was a problem hiding this comment.
remove !!
not needed since you have >= 2
per Frank's comment of unneeded !! for comparing version number >= 2
fbarchard
reviewed
Feb 1, 2025
src/x86/isa.c
Outdated
| (max_base_index >= 7) ? cpuidex(7, 0) : (struct cpuid_regs){0, 0, 0, 0}; | ||
| const struct cpuid_regs structured_feature_info1 = | ||
| (max_base_index >= 7) ? cpuidex(7, 1) : (struct cpuid_regs){0, 0, 0, 0}; | ||
| const struct cpuid_regs structured_feature_info2 = |
Collaborator
There was a problem hiding this comment.
indent is wrong. should be 1 tab of 8 instead of 4 spaces.
copy the indent from the lines above
fixed white spaces changing incorrect tab and space for alignment.
Update spaces to tabs to fix alignment issues.
fix the spaces to tab at line 50 to fix indenting issue.
fbarchard
approved these changes
Feb 3, 2025
digantdesai
approved these changes
Feb 3, 2025
Contributor
|
Thanks @rrwinterton @fbarchard |
Contributor
|
hmm CI didn't run for some reason :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to CPU Info to detect AVX 10.2 Instructions. This is the next version of ISA for x86 AVX 10.