pkg-config: use PROJECT_NAME instead of CMAKE_PROJECT_NAME #277
Conversation
[`PROJECT_NAME`][1] refers to the most recent `project()` call, while [`CMAKE_PROJECT_NAME`][2] refers to the top-most `project()` call. In the cases where cpuinfo is installed as a standalone project, this is perfectly fine and works as intended where the installed pkg-config file contains libcpuinfo as the name. However, if cpuinfo is used as a subproject, such as when using FetchContent, the name of the calling project would be used instead, leading to something like libOuterProject rather than libcpuinfo. [1]: https://cmake.org/cmake/help/latest/variable/PROJECT_NAME.html#variable:PROJECT_NAME [2]: https://cmake.org/cmake/help/latest/variable/CMAKE_PROJECT_NAME.html#variable:CMAKE_PROJECT_NAME Signed-off-by: Christopher Degawa <ccom@randomderp.com>
|
Hi @1480c1! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@1480c1 - Thanks for the fix. Please sign CLA before we can move forward. |
Based on the bot's response, I believe I have? |
3 participants
PROJECT_NAMErefers to the most recentproject()call, whileCMAKE_PROJECT_NAMErefers to the top-mostproject()call.In the cases where cpuinfo is installed as a standalone project, this is
perfectly fine and works as intended where the installed pkg-config file
contains libcpuinfo as the name. However, if cpuinfo is used as a
subproject, such as when using FetchContent, the name of the calling
project would be used instead, leading to something like libOuterProject
rather than libcpuinfo.