Add fallback for ARM Windows fp16 detection. #348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: On a Windows ARM system, I observed that
cpuinfo_has_arm_fp16_arith()started to return false after upgrading to a more recent cpuinfo version.In #333, the initialization of
cpuinfo_isa.fp16arithwas updated to useIsProcessorFeaturePresent(PF_ARM_V82_FP16_INSTRUCTIONS_AVAILABLE). I suspect that this is not supported on older Windows versions.This change adds a fallback path to set
cpuinfo_isa.fp16ariththe old way.cpuinfo/src/arm/windows/init.c
Lines 205 to 208 in d3a86a8