-
Notifications
You must be signed in to change notification settings - Fork 371
Add support for CMAKE_OSX_ARCHITECTURES #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Plan: On x86_64 Mac: cmake -DCMAKE_OSX_ARCHITECTURES=arm64 -DCPUINFO_BUILD_BENCHMARKS=OFF .. -G Ninja ninja On M1 Mac: cmake -DCMAKE_OSX_ARCHITECTURES=x86_64 -DCPUINFO_BUILD_BENCHMARKS=OFF .. -G Ninja ninja Then copy and execute build artifacts on a different platform
Maratyszcza
reviewed
Dec 17, 2020
Maratyszcza
reviewed
Dec 17, 2020
Maratyszcza
approved these changes
Dec 17, 2020
malfet
added a commit
to pytorch/pytorch
that referenced
this pull request
Dec 21, 2020
malfet
added a commit
to pytorch/pytorch
that referenced
this pull request
Dec 21, 2020
Introduce changes similar to pytorch/cpuinfo#51 to detect that PyTorch is build on MacOS for different architecture Test Plan: Pull shibatch/sleef#376 and run `cmake -DCMAKE_OSX_ARCHITECTURES=x86_64 -DPYTHON_EXECUTABLE=/usr/bin/python3 -DUSE_NNPACK=NO -DUSE_XNNPACK=NO -DBUILD_TEST=YES .. -G Ninja; ninja basic`
malfet
added a commit
to pytorch/pytorch
that referenced
this pull request
Dec 22, 2020
malfet
added a commit
to pytorch/pytorch
that referenced
this pull request
Dec 22, 2020
Introduce changes similar to pytorch/cpuinfo#51 to detect that PyTorch is build on MacOS for different architecture Test Plan: Pull shibatch/sleef#376 and run `cmake -DCMAKE_OSX_ARCHITECTURES=x86_64 -DPYTHON_EXECUTABLE=/usr/bin/python3 -DUSE_NNPACK=NO -DUSE_XNNPACK=NO -DBUILD_TEST=YES .. -G Ninja; ninja basic`
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Dec 22, 2020
Summary: Update CPUINFO to include pytorch/cpuinfo#51 Update sleef to include shibatch/sleef#376 Modify aten/src/ATen/native/quantized/cpu/qnnpack/CMakeLists.txt to recognize CMAKE_OSX_ARCHITECTURES Pull Request resolved: #49701 Test Plan: `cmake -DCMAKE_OSX_ARCHITECTURES=x86_64 -DPYTHON_EXECUTABLE=/usr/bin/python3 -DUSE_XNNPACK=NO -DBUILD_TEST=YES .. -G Ninja; ninja basic` finishes successfully on Apple M1 Reviewed By: janeyx99 Differential Revision: D25669219 Pulled By: malfet fbshipit-source-id: 5ee36b64e3a7ac76448f2a300ac4993375a26de5
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
Summary: Update CPUINFO to include pytorch/cpuinfo#51 Update sleef to include shibatch/sleef#376 Modify aten/src/ATen/native/quantized/cpu/qnnpack/CMakeLists.txt to recognize CMAKE_OSX_ARCHITECTURES Pull Request resolved: pytorch#49701 Test Plan: `cmake -DCMAKE_OSX_ARCHITECTURES=x86_64 -DPYTHON_EXECUTABLE=/usr/bin/python3 -DUSE_XNNPACK=NO -DBUILD_TEST=YES .. -G Ninja; ninja basic` finishes successfully on Apple M1 Reviewed By: janeyx99 Differential Revision: D25669219 Pulled By: malfet fbshipit-source-id: 5ee36b64e3a7ac76448f2a300ac4993375a26de5
megengine-bot
pushed a commit
to MegEngine/cpuinfo
that referenced
this pull request
Sep 5, 2022
* Add support for CMAKE_OSX_ARCHITECTURES Test Plan: On x86_64 Mac: cmake -DCMAKE_OSX_ARCHITECTURES=arm64 -DCPUINFO_BUILD_BENCHMARKS=OFF .. -G Ninja ninja On M1 Mac: cmake -DCMAKE_OSX_ARCHITECTURES=x86_64 -DCPUINFO_BUILD_BENCHMARKS=OFF .. -G Ninja ninja Then copy and execute build artifacts on a different platform * Incorporate review feedback GitOrigin-RevId: 5916273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan:
On x86_64 Mac:
cmake -DCMAKE_OSX_ARCHITECTURES=arm64 -DCPUINFO_BUILD_BENCHMARKS=OFF .. -G Ninja
ninja
On M1 Mac:
cmake -DCMAKE_OSX_ARCHITECTURES=x86_64 -DCPUINFO_BUILD_BENCHMARKS=OFF .. -G Ninja
ninja
Then copy and execute build artifacts on a different platform