Skip to content

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Dec 17, 2020

Test Plan:
On x86_64 Mac:
cmake -DCMAKE_OSX_ARCHITECTURES=arm64 -DCPUINFO_BUILD_BENCHMARKS=OFF .. -G Ninja
ninja
On M1 Mac:
cmake -DCMAKE_OSX_ARCHITECTURES=x86_64 -DCPUINFO_BUILD_BENCHMARKS=OFF .. -G Ninja
ninja
Then copy and execute build artifacts on a different platform

Test Plan:
On x86_64 Mac:
 cmake -DCMAKE_OSX_ARCHITECTURES=arm64 -DCPUINFO_BUILD_BENCHMARKS=OFF .. -G Ninja
 ninja
On M1 Mac:
  cmake -DCMAKE_OSX_ARCHITECTURES=x86_64 -DCPUINFO_BUILD_BENCHMARKS=OFF .. -G Ninja
  ninja
Then copy and execute build artifacts on a different platform
@malfet malfet merged commit 5916273 into master Dec 17, 2020
@malfet malfet deleted the malfet/add-support-for-osx-architectures branch December 17, 2020 20:05
malfet added a commit to pytorch/pytorch that referenced this pull request Dec 21, 2020
malfet added a commit to pytorch/pytorch that referenced this pull request Dec 21, 2020
Introduce changes similar to pytorch/cpuinfo#51 to detect that PyTorch is build on MacOS  for different architecture

Test Plan:
  Pull shibatch/sleef#376 and run `cmake -DCMAKE_OSX_ARCHITECTURES=x86_64 -DPYTHON_EXECUTABLE=/usr/bin/python3 -DUSE_NNPACK=NO -DUSE_XNNPACK=NO -DBUILD_TEST=YES .. -G Ninja; ninja basic`
malfet added a commit to pytorch/pytorch that referenced this pull request Dec 22, 2020
malfet added a commit to pytorch/pytorch that referenced this pull request Dec 22, 2020
Introduce changes similar to pytorch/cpuinfo#51 to detect that PyTorch is build on MacOS  for different architecture

Test Plan:
  Pull shibatch/sleef#376 and run `cmake -DCMAKE_OSX_ARCHITECTURES=x86_64 -DPYTHON_EXECUTABLE=/usr/bin/python3 -DUSE_NNPACK=NO -DUSE_XNNPACK=NO -DBUILD_TEST=YES .. -G Ninja; ninja basic`
facebook-github-bot pushed a commit to pytorch/pytorch that referenced this pull request Dec 22, 2020
Summary:
Update CPUINFO to include pytorch/cpuinfo#51
Update sleef to include shibatch/sleef#376
Modify aten/src/ATen/native/quantized/cpu/qnnpack/CMakeLists.txt to recognize CMAKE_OSX_ARCHITECTURES

Pull Request resolved: #49701

Test Plan: `cmake -DCMAKE_OSX_ARCHITECTURES=x86_64 -DPYTHON_EXECUTABLE=/usr/bin/python3  -DUSE_XNNPACK=NO -DBUILD_TEST=YES .. -G Ninja; ninja basic` finishes successfully on Apple M1

Reviewed By: janeyx99

Differential Revision: D25669219

Pulled By: malfet

fbshipit-source-id: 5ee36b64e3a7ac76448f2a300ac4993375a26de5
hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 6, 2021
Summary:
Update CPUINFO to include pytorch/cpuinfo#51
Update sleef to include shibatch/sleef#376
Modify aten/src/ATen/native/quantized/cpu/qnnpack/CMakeLists.txt to recognize CMAKE_OSX_ARCHITECTURES

Pull Request resolved: pytorch#49701

Test Plan: `cmake -DCMAKE_OSX_ARCHITECTURES=x86_64 -DPYTHON_EXECUTABLE=/usr/bin/python3  -DUSE_XNNPACK=NO -DBUILD_TEST=YES .. -G Ninja; ninja basic` finishes successfully on Apple M1

Reviewed By: janeyx99

Differential Revision: D25669219

Pulled By: malfet

fbshipit-source-id: 5ee36b64e3a7ac76448f2a300ac4993375a26de5
megengine-bot pushed a commit to MegEngine/cpuinfo that referenced this pull request Sep 5, 2022
* Add support for CMAKE_OSX_ARCHITECTURES

Test Plan:
On x86_64 Mac:
 cmake -DCMAKE_OSX_ARCHITECTURES=arm64 -DCPUINFO_BUILD_BENCHMARKS=OFF .. -G Ninja
 ninja
On M1 Mac:
  cmake -DCMAKE_OSX_ARCHITECTURES=x86_64 -DCPUINFO_BUILD_BENCHMARKS=OFF .. -G Ninja
  ninja
Then copy and execute build artifacts on a different platform

* Incorporate review feedback

GitOrigin-RevId: 5916273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants