--skip-fvp-setup flag is ignored

[armwaheed]

executorch/examples/arm/setup.sh

Line 107 in fee2bd9

--skip-fvp-setup)

The --skip-fvp-setup is ignored because the setup.sh unconditionally calls:

$et_dir/backends/arm/scripts/install_reference_model.sh ${root_dir}

This line downloads and builds the TOSA reference model, which itself requires the FVP binaries.

Recommend just removing the --skip-fvp-setup entirely.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

[guangy10]

@armwaheed Does it cause any issue with --skip-fvp-setup be ignored. As how I read it, you are suggesting an improvement instead of reporting a bug, correct?

The --skip-fvp-setup is ignored because the setup.sh unconditionally calls

@digantdesai is it expected? We can remove it if no longer needed.

[armwaheed]

Thanks @guangy10. Correct, this is not a bug, just an improvement (more like a nit). --skip-fvp-setup isn't doing any harm, because it really isn't doing anything at all

[digantdesai]

This line downloads and builds the TOSA reference model, which itself requires the FVP binaries.

Why would TOSA reference model require FVP binaries?

[YufengShi-dudu]

The --skip-fvp-setup has been deprecated in this PR #12397

[armwaheed]

Why would TOSA reference model require FVP binaries?

@digantdesai, it seems to be a hard coded dependency, I'm assuming for model validation checks?

[digantdesai]

it seems to be a hard coded dependency

Code link?

[armwaheed]

it seems to be a hard coded dependency

Code link?

Thanks @digantdesai for your patience. You're right, it's not the TOSA install causing the FVP dependency issue. Apologies for the misleading guess, I hadn't yet had time to fully investigate.

https://github.com/pytorch/executorch/blob/main/examples/arm/setup.sh#L23 looks like the main culprit actually:

enable_fvps=1

Secondary cause is https://github.com/pytorch/executorch/blob/main/examples/arm/setup.sh#L221-L223

function setup_fvp() {
    # check EULA, forward argument
    check_fvp_eula

Later on, run.sh also has a FVP dependency; https://github.com/pytorch/executorch/blob/main/examples/arm/run.sh#L278-L282:

      if [ "$build_only" = false ] ; then
          # Execute the executor_runner on FVP Simulator
          elf_file="${output_folder}/${elf_folder}/cmake-out/arm_executor_runner"
          backends/arm/scripts/run_fvp.sh --elf=${elf_file} --target=$target
      fi