Remove strictness in export calls #10552
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10552
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Cancelled Jobs, 27 Unrelated FailuresAs of commit f610cf5 with merge base 97047c0 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73859317 |
mcremon-meta
added a commit
that referenced
this pull request
Apr 29, 2025
Summary: The new PT default has been to do non-strict export for a little while now. We have explicit strict because the PT compiler team preserved the current behavior at the time, but we should be able to remove it and match the default. It might also make more models go through. Differential Revision: D73859317
mcremon-meta
force-pushed
the
export-D73859317
branch
from
c7a51c6 to
850c6e4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73859317 |
mcremon-meta
force-pushed
the
export-D73859317
branch
from
850c6e4 to
0e7a2f6
Compare
mcremon-meta
added a commit
that referenced
this pull request
Apr 29, 2025
Summary: Pull Request resolved: #10552 The new PT default has been to do non-strict export for a little while now. We have explicit strict because the PT compiler team preserved the current behavior at the time, but we should be able to remove it and match the default. It might also make more models go through. Differential Revision: D73859317
mcremon-meta
added a commit
that referenced
this pull request
Jul 7, 2025
Summary: The new PT default has been to do non-strict export for a little while now. We have explicit strict because the PT compiler team preserved the current behavior at the time, but we should be able to remove it and match the default. It might also make more models go through. Differential Revision: D73859317
mcremon-meta
force-pushed
the
export-D73859317
branch
from
0e7a2f6 to
1801dac
Compare
This PR needs a
|
Summary: Pull Request resolved: #10552 The new PT default has been to do non-strict export for a little while now. We have explicit strict because the PT compiler team preserved the current behavior at the time, but we should be able to remove it and match the default. It might also make more models go through. Differential Revision: D73859317
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73859317 |
mcremon-meta
force-pushed
the
export-D73859317
branch
from
1801dac to
f610cf5
Compare
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The new PT default has been to do non-strict export for a little while now. We have explicit strict because the PT compiler team preserved the current behavior at the time, but we should be able to remove it and match the default. It might also make more models go through.
Differential Revision: D73859317