Skip to content

Conversation

@SaoirseARM
Copy link
Collaborator

@SaoirseARM SaoirseARM commented May 15, 2025

Summary

Update model unit tests to use the new test infrastructure pipeline.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Signed-off-by: Saoirse Stewart <saoirse.stewart@arm.com>

Change-Id: Ib8581f3aa9f879572b80dea8dd9e0c789b00c517
@SaoirseARM SaoirseARM requested a review from zingo May 15, 2025 14:00
@SaoirseARM SaoirseARM requested a review from digantdesai as a code owner May 15, 2025 14:00
@pytorch-bot
Copy link

pytorch-bot bot commented May 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10904

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d45fe19 with merge base b73f9d5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 15, 2025
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label May 15, 2025
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label May 15, 2025
@zingo
Copy link
Collaborator

zingo commented May 15, 2025

@SaoirseARM This seem to get a model errror
FAILED backends/arm/test/models/test_dl3_arm.py::test_dl3_u85_BI - RuntimeError: Corstone simulation failed:
It seem to allocate to much memory :(

@zingo
Copy link
Collaborator

zingo commented May 16, 2025

Rebased to get lintrunner to work and force a recheck to see that dl3 is still giving the error.

EDIT: A proper rebase with a fix for the test problem was merged right after my rebase so ignore this comment

@zingo
Copy link
Collaborator

zingo commented May 19, 2025

Hm worder if we need to add something to rtol (or atol) also

FAILED backends/arm/test/models/test_dl3_arm.py::test_dl3_tosa_BI - AssertionError: Output 0 does not match reference output.
Given atol: 1.0, rtol: 0.001.
Output tensor shape: torch.Size([1, 21, 224, 224]), dtype: torch.float32
Difference: max: 1.0140552520751953, abs: 1.0140552520751953, mean abs error: 0.07422800362110138.
-- Model vs. Reference --
Numel: 1053696, 1053696
Median: -0.4148407280445099, -0.4148407280445099
Mean: 0.0011951494961977005, 0.0009040239383466542
Max: 7.881974220275879, 7.928067684173584
Min: -3.5952863693237305, -3.5952863693237305
= 1 failed, 62 passed, 4 skipped, 20 xfailed, 3 xpassed, 1373 warnings in 812.75s (0:13:32) =

@zingo
Copy link
Collaborator

zingo commented May 19, 2025

Rebased after unrelated Arm test fixes

@zingo zingo merged commit d509ee3 into pytorch:main May 20, 2025
183 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants