Skip to content

Conversation

@iseeyuan
Copy link
Contributor

In scripts/build_android_library.sh, there's

ANDROID_HOME="${ANDROID_SDK:-/opt/android/sdk}" ./gradlew build

If ANDROID_SDK is not set, ANDROID_HOME will be /opt/android/sdk, which is wrong for Mac. Add export ANDROID_SDK instruction to avoid the build error if users have not exported it.

Test plan

sh scripts/build_android_library.sh

In scripts/build_android_library.sh, there's 
```
ANDROID_HOME="${ANDROID_SDK:-/opt/android/sdk}" ./gradlew build
```
If ANDROID_SDK is not set, ANDROID_HOME will be /opt/android/sdk, which is wrong for Mac. Add `export ANDROID_SDK` instruction to avoid the build error if users have not exported it.
@pytorch-bot
Copy link

pytorch-bot bot commented May 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10956

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 1 Unrelated Failure

As of commit 045a8af with merge base 9aaea31 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 17, 2025
@iseeyuan
Copy link
Contributor Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label May 21, 2025
@iseeyuan iseeyuan merged commit ed718a8 into main May 21, 2025
93 of 97 checks passed
@iseeyuan iseeyuan deleted the iseeyuan-patch-13 branch May 21, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants