Skip to content

Conversation

@manuelcandales
Copy link
Contributor

@manuelcandales manuelcandales commented Jul 8, 2025

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12279

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit c5bc22b with merge base ba19c75 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

manuelcandales added a commit that referenced this pull request Jul 8, 2025
Differential Revision: [D77775717](https://our.internmc.facebook.com/intern/diff/D77775717/)

ghstack-source-id: 294877448
Pull Request resolved: #12279
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 8, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77775717

@manuelcandales manuelcandales added the release notes: none Do not include this in the release notes label Jul 8, 2025
Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the lambda comments were out of date?

@facebook-github-bot facebook-github-bot merged commit 98f3746 into gh/manuelcandales/132/base Jul 8, 2025
97 of 102 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/manuelcandales/132/head branch July 8, 2025 22:10
manuelcandales added a commit that referenced this pull request Jul 9, 2025
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #12279 by
@manuelcandales
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/manuelcandales/132/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/manuelcandales/132/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/manuelcandales/131/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/manuelcandales/132/orig
@diff-train-skip-merge

---------

Co-authored-by: Manuel Candales <manuelcandales@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants