draff diff for pybindings task #12790 #12909
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12909
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4398638 with merge base 0b8d99f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This PR needs a
|
extension/llm/runner/CMakeLists.txt
Outdated
| target_link_libraries(runner PRIVATE ${runner_dep_libs}) | ||
|
|
||
| install(TARGETS extension_llm_runner | ||
| LIBRARY DESTINATION executorch/extension/training/pybindings |
There was a problem hiding this comment.
Don't install it in training directory. Install it under extension/llm/runner
setup.py
Outdated
| dependent_cmake_flags=["EXECUTORCH_BUILD_EXTENSION_TRAINING"], | ||
| ), | ||
| BuiltExtension( | ||
| src="extension/llm/runner/python_bindings*", # @lint-ignore https://github.com/pytorch/executorch/blob/cb3eba0d7f630bc8cec0a9cc1df8ae2f17af3f7a/scripts/lint_xrefs.sh |
There was a problem hiding this comment.
- your path is incorrect, see comment above about install location
- your output filename is incorrect, it should be something like
runner.sonamed after your pybind11 module name.
|
Hi @jasshone! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
3 participants
Summary
Tries to add pybindings for llm runner class
Fixes ##12790
Test plan
functionality does not work, draff diff