Skip to content

make to_edge_transform_and_lower support etrecord generation #13034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 2, 2025
Merged

make to_edge_transform_and_lower support etrecord generation #13034

merged 5 commits into from
Aug 2, 2025

Conversation

Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Jul 31, 2025 •
edited
Loading

This was referenced Jul 31, 2025
Merged
Merged
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 31, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13034

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures

As of commit 075341a with merge base 8651d31 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 31, 2025
Gasoonjia added a commit that referenced this pull request Jul 31, 2025
@Gasoonjia
make to_edge_transform_and_lower support etrecord generation
da08ecb 
Differential Revision: [D79336982](https://our.internmc.facebook.com/intern/diff/D79336982/)

ghstack-source-id: 299779126
Pull Request resolved: #13034
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79336982

@Gasoonjia Gasoonjia mentioned this pull request Jul 31, 2025
Closed
Gasoonjia added a commit that referenced this pull request Jul 31, 2025
@Gasoonjia
make to_edge_transform_and_lower support etrecord generation
c847a7e 
Pull Request resolved: #13034

This diff focus on making `to_edge_transform_and_lower` pipeline support etrecord generation, which can not work on etrecord generation at all previously.

Also add tests into it.

ghstack-source-id: 299899083
@exported-using-ghexport

Differential Revision: [D79336982](https://our.internmc.facebook.com/intern/diff/D79336982/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79336982

Gasoonjia added a commit that referenced this pull request Jul 31, 2025
@Gasoonjia
make to_edge_transform_and_lower support etrecord generation
3d4c111 
Pull Request resolved: #13034

This diff focus on making `to_edge_transform_and_lower` pipeline support etrecord generation, which can not work on etrecord generation at all previously.

Also add tests into it.

ghstack-source-id: 299903999
@exported-using-ghexport

Differential Revision: [D79336982](https://our.internmc.facebook.com/intern/diff/D79336982/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79336982

@GregoryComer
Copy link
Member

GregoryComer commented Jul 31, 2025 •
edited
Loading

It might be worth adding a test that covers to_edge_transform_and_lower with a partitioner. The logic might already handle this case, but to_backend creates a new edge program manager and is only called internally when a partitioner is provided. It might need some extra logic for this case to propagate the edge manager in to_backend.

@Gasoonjia Gasoonjia mentioned this pull request Jul 31, 2025
Merged
@Gasoonjia Gasoonjia mentioned this pull request Aug 1, 2025
Merged
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79336982

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79336982

@facebook-github-bot facebook-github-bot merged commit cabfef4 into gh/gasoonjia/32/base Aug 2, 2025
101 of 104 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/gasoonjia/32/head branch August 2, 2025 00:00
@pytorchbot pytorchbot mentioned this pull request Aug 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackzhxng jackzhxng jackzhxng approved these changes

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Gasoonjia @facebook-github-bot @GregoryComer @jackzhxng