Skip to content

[TOSA] Replace Linear lowering of using Matmul with Conv2d #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

[TOSA] Replace Linear lowering of using Matmul with Conv2d #1311

wants to merge 0 commits into from

Conversation

@Jerry-Ge
Copy link
Contributor

  • The existing Vela compiler doesn't support Matmul and TOSA.Fully_Connected will be deprecated
  • Also add support for linear layers with rank>2 + tests

@Jerry-Ge Jerry-Ge added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Nov 29, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 29, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 29, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1311

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Jerry-Ge
Copy link
Contributor Author

the lintrunner failure was caused by something irrelevant exir/emit/test/test_emit.py

@Jerry-Ge Jerry-Ge mentioned this pull request Nov 30, 2023
Closed
@Jerry-Ge Jerry-Ge force-pushed the main branch 5 times, most recently from d94de7f to 3d00901 Compare December 1, 2023 23:38
@Jerry-Ge Jerry-Ge closed this Dec 1, 2023
@Jerry-Ge
Copy link
Contributor Author

Jerry-Ge commented Dec 1, 2023 •
edited
Loading

sorry, screwed up this patch. will create a new one here: #1336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai Awaiting requested review from digantdesai

@cccclai cccclai Awaiting requested review from cccclai

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jerry-Ge @facebook-github-bot