Skip to content

Fix remaining instances of for aten in (True, False): #13529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

Fix remaining instances of for aten in (True, False): #13529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdbd83b
Update
swolchok Aug 19, 2025
57e843c
rebase
swolchok Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/models/llama/runner/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "get_aten_mode_options", "runtime")

def _get_operator_lib(aten = False):
if aten:
Expand All @@ -18,7 +18,7 @@ def get_qnn_dependency():
return []

def define_common_targets():
for aten in (True, False):
for aten in get_aten_mode_options():
aten_suffix = "_aten" if aten else ""
runtime.cxx_library(
name = "runner" + aten_suffix,
Expand Down
4 changes: 2 additions & 2 deletions examples/models/llama/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "get_oss_build_kwargs", "runtime")
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "get_aten_mode_options", "get_oss_build_kwargs", "runtime")

def define_common_targets():
for aten in (True, False):
for aten in get_aten_mode_options():
if not runtime.is_oss or not aten:
aten_suffix = "_aten" if aten else ""

Expand Down
4 changes: 2 additions & 2 deletions extension/llm/sampler/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "get_aten_mode_options", "runtime")

def define_common_targets():
for aten in (True, False):
for aten in get_aten_mode_options():
aten_suffix = "_aten" if aten else ""

runtime.cxx_library(
Expand Down
Loading