Skip to content

Conversation

@kirklandsign
Copy link
Contributor

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13825

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 62 Pending

As of commit bb2bfe0 with merge base b759ae8 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 29, 2025
@kirklandsign kirklandsign marked this pull request as ready for review September 3, 2025 23:08
Copy link
Contributor

@jackzhxng jackzhxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, how did you test?

@kirklandsign
Copy link
Contributor Author

Nice, how did you test?

Honestly not sure how to test multimodal. I can just check for llama regression for now.

Maybe llava? Do you have idea?

@jackzhxng
Copy link
Contributor

Yeah, I think just checking Llama for regression would be good for now

@kirklandsign
Copy link
Contributor Author

Yeah, I think just checking Llama for regression would be good for now

Validated

@mergennachin
Copy link
Contributor

@kirklandsign Is there a test for jni layer?

@kirklandsign
Copy link
Contributor Author

@kirklandsign Is there a test for jni layer?

No. We use E2E CI.

However, I have trouble with validating this. Multimodal runner requires method get_max_seq_len but when I tried to export llava, seems this method is missing.

@kirklandsign
Copy link
Contributor Author

I have some difficulty validating this. Getting error

Attempted to resize a static tensor. Expected shape (1), but received (4).
Error resizing tensor at input 0

auto prefill_result = module_->execute(
kTextModelMethod, {cache_position_tensor, encoder_output});

@jackzhxng
Copy link
Contributor

@kirklandsign is this for text prefill or image prefill? If it's text prefill, then you should check if the encoder embeddings has a batch dimension

@kirklandsign
Copy link
Contributor Author

@kirklandsign is this for text prefill or image prefill? If it's text prefill, then you should check if the encoder embeddings has a batch dimension

text.

@kirklandsign
Copy link
Contributor Author

Now the part I'm not sure is

{static_cast<int>(seq_len)},

which is different from llava runner

&start_pos, {1}, executorch::aten::ScalarType::Long);

Otherwise we can merge this PR

@kirklandsign kirklandsign merged commit de0ff26 into main Sep 9, 2025
279 of 285 checks passed
@kirklandsign kirklandsign deleted the jni-layer-llama-1 branch September 9, 2025 03:43
@kirklandsign kirklandsign added the release notes: android Android Java and JNI code label Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: android Android Java and JNI code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants