Skip to content

Conversation

@wwwind
Copy link
Collaborator

@wwwind wwwind commented Sep 5, 2025

This change allows us to preserve output order after export.

Change-Id: I7ee55c2877ca1b247f10d2e90da3ba38dc727b6f
Signed-off-by: Elena Zhelezina elena.zhelezina@arm.com

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

This change allows us to preserve output order after export.

Change-Id: I7ee55c2877ca1b247f10d2e90da3ba38dc727b6f
Signed-off-by: Elena Zhelezina <elena.zhelezina@arm.com>
@wwwind wwwind requested a review from digantdesai as a code owner September 5, 2025 12:29
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13997

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit c53ab9f with merge base 6c12956 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2025
@wwwind wwwind added ciflow/trunk partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate labels Sep 5, 2025
@wwwind
Copy link
Collaborator Author

wwwind commented Sep 5, 2025

replacement for #13454 which is too old to update

@zingo
Copy link
Collaborator

zingo commented Sep 5, 2025

Got the error below on [pull / unittest-arm-backend-with-no-fvp (test_pytest_ops) / linux-job (pull_request)]
Retriggering to see if it's random.

FAILED backends/arm/test/misc/test_debug_feats.py::test_dump_tosa_debug_json[randn] - assert []
ERROR backends/arm/test/misc/test_outputs_order.py
= 1 failed, 2877 passed, 2404 skipped, 1827 xfailed, 133 xpassed, 4476 warnings, 1 error in 2480.77s (0:41:20) =

@zingo
Copy link
Collaborator

zingo commented Sep 5, 2025

Got the same error in
trunk / test-arm-backend (test_pytest_ops_ethosu_fvp) / linux-job (push)

@wwwind fails might unfortunately be related to the change. :(

@wwwind
Copy link
Collaborator Author

wwwind commented Sep 5, 2025

@zingo Thank you! I will take a look. I run this CR yesterday through all our tests in CI and it was green

Change-Id: Iee6ae28e98d2a8bdb1e45347a9bf9a8cb31020a9
@wwwind
Copy link
Collaborator Author

wwwind commented Sep 5, 2025

@zingo found the issue - should be fixed now 🤞

Change-Id: I97e4022ede97deb71323a83c101077247714bdda
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Déjà vu? :)

Change-Id: I5a25a990c9aa2f762a882be3f958df86e40f550e
@zingo zingo merged commit d324799 into pytorch:main Sep 9, 2025
447 of 450 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants