Skip to content

Remove SoftmaxQuantizer #14089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JakeStevens wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove SoftmaxQuantizer #14089

JakeStevens wants to merge 1 commit into from

Conversation

@JakeStevens
Copy link
Contributor

@JakeStevens JakeStevens commented Sep 8, 2025

Summary:
Softmax not supported on current platforms.

This introduces quant/dequants into the graph, which are unneeded.

This diff removes the quantizer until supported.

Differential Revision: D81964057

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14089

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3cd9458 with merge base 245630a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 8, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 8, 2025

This pull request was exported from Phabricator. Differential Revision: D81964057

@github-actions
Copy link

github-actions bot commented Sep 8, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Sep 9, 2025
@JakeStevens @facebook-github-bot
Remove SoftmaxQuantizer (pytorch#14089)
32bde64 
Summary:

Softmax not supported on current platforms.

This introduces quant/dequants into the graph, which are unneeded.

This diff removes the quantizer until supported.

Differential Revision: D81964057
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 9, 2025

This pull request was exported from Phabricator. Differential Revision: D81964057

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Sep 9, 2025
@JakeStevens @facebook-github-bot
Remove SoftmaxQuantizer (pytorch#14089)
bd05a44 
Summary:

Softmax not supported on current platforms.

This introduces quant/dequants into the graph, which are unneeded.

This diff removes the quantizer until supported.

Differential Revision: D81964057
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 9, 2025

This pull request was exported from Phabricator. Differential Revision: D81964057

JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Sep 9, 2025
@JakeStevens @facebook-github-bot
Remove SoftmaxQuantizer (pytorch#14089)
fc4d0b6 
Summary:
Pull Request resolved: pytorch#14089

Softmax not supported on current platforms.

This introduces quant/dequants into the graph, which are unneeded.

This diff removes the quantizer until supported.

Differential Revision: D81964057
JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Sep 9, 2025
@JakeStevens @facebook-github-bot
Remove SoftmaxQuantizer (pytorch#14089)
0bc8f4c 
Summary:

Softmax not supported on current platforms.

This introduces quant/dequants into the graph, which are unneeded.

This diff removes the quantizer until supported.

Differential Revision: D81964057
@JakeStevens @facebook-github-bot
Remove SoftmaxQuantizer (pytorch#14089)
3cd9458 
Summary:
Pull Request resolved: pytorch#14089

Softmax not supported on current platforms.

This introduces quant/dequants into the graph, which are unneeded.

This diff removes the quantizer until supported.

Differential Revision: D81964057
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 9, 2025

This pull request was exported from Phabricator. Differential Revision: D81964057

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported stale PRs inactive for over 60 days

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JakeStevens @facebook-github-bot