Skip to content

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Sep 10, 2025

We are supposed to be using this everywhere IIUC, but there were a bunch of files not doing it. Mass find/replace.

Differential Revision: D82127662

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Sep 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14153

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 5 Unrelated Failures

As of commit ef79a05 with merge base 53b7ec5 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2025
@swolchok swolchok added the release notes: none Do not include this in the release notes label Sep 10, 2025
@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@swolchok
Copy link
Contributor Author

we'll want to land this internally first so it goes through checks; please don't merge it here

[ghstack-poisoned]
[ghstack-poisoned]
@swolchok swolchok changed the base branch from main to gh/swolchok/568/head September 10, 2025 21:52
@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Base automatically changed from gh/swolchok/568/head to main September 11, 2025 16:28
@facebook-github-bot facebook-github-bot merged commit 39bdb41 into main Sep 11, 2025
115 of 141 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/swolchok/561/head branch September 11, 2025 16:29
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
Differential Revision: D82127662

Pull Request resolved: pytorch#14153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants